-
Notifications
You must be signed in to change notification settings - Fork 899
Target .NET Standard 1.3 #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target .NET Standard 1.3 #1318
Changes from all commits
442f626
d7ef5f3
68ee9b7
e08f9e5
ef51bef
61176b8
6704b7d
b6aa86d
2e32bb0
4cc6acd
6a2fb6b
e94a7b2
9067041
3c8ab4b
370cdfa
2557d8c
9abdff2
250599c
a4a2383
476e4be
da5e55c
bf7ad91
e7d9457
5d58dfa
7971833
12253be
41ee5d3
fe10951
aceef06
0bae5e3
555940f
2900cf5
b30f625
f5caa81
1315693
02a4e53
b44040d
e6c3696
682273a
14555f3
ebd3b1f
9a94aa9
2d1f183
a85fc40
2146e59
9539829
8566e31
d225524
3f95f3c
61aaf28
da0adef
a07390c
ba8c334
fed0ecf
d5d6c38
dfb9129
403971f
e876ff8
3129cc7
61372a7
c0cf832
803e499
e710875
09c71e0
4998f1b
38cfbcc
5610f27
f2543ec
9fca61f
4ca2bbb
d851767
a6f4cd6
fe1533a
64a07e2
920e596
48f73d0
4b2be46
8eefe0a
d235f8a
a240072
bbf0096
58a537f
847ad24
c0171a4
17741a6
fca8128
9ad39f9
c1541e9
7d87fc2
f2bf103
e3888f8
028aeb3
9bf4fd8
2604004
8e690f9
c358bc3
1f4f58b
3f9b0f9
bef8217
b856f9b
ea00328
40832ff
8e785fc
aaec99c
b43c6ed
131dec0
f37bf43
cc219fd
514282c
6a106f7
9eb4cde
e418992
f29c7a8
3a01c5c
eb6c84e
6c82177
a5d59d0
9828971
808c17b
480db0b
2e039e1
4e6b2c2
a64efe5
a60c102
400cb37
75823e8
b42c92d
c60b162
c503a0c
dd6de03
5bdd563
7067eb5
77b6fa4
c38e696
0620c68
fee5414
fee9a1f
7c361f7
b8d08c7
8ca086e
d22ab08
4d13ef7
dc8e4a3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<Project Sdk="Microsoft.NET.Sdk"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While the workaround to get this working properly was to commit the assembly directly vs building it, would it be worth including in the VS solution so it shows up at least? Also, why is the folder where the assembly is saved called There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If it's in the solution file, it will build (unless I do rather unusual things that will likely confuse folks). And if I leave it building, folks will expect that is meaningful for something in the product, and it isn't. Also, if it's in the solution, then package restore has to bring down more packages as this project has unique ones. So it will slow down package restore and builds on CIs and dev machines with no value. As it stands alone, it can be built as a lone project without an sln. So in the rare event we may actually need to update the code gen project, we can still do that -- and possibly add it to its own temporary solution at that time. lkg = Last Known Good. In my work experience lkg is used to refer to a checked in toolset, which is exactly what this is. We build the toolset (or at least this small part of it), then we check it in so we can use it next time without building it first. If we were to update the toolset, we'd test it, then we'd check it in as the 'last known good' version has updated. I'm not passionate about the name. I'm happy to rename it if you'd prefer something else. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
That makes sense. No reason to add it, then.
I don't recall ever coming across that acronym before, so thanks for the explanation. I can't immediately think of something else I'd prefer, so seems OK to stick with |
||
<PropertyGroup> | ||
<TargetFramework>netstandard1.5</TargetFramework> | ||
<PackageTargetFallback>$(PackageTargetFallback);portable-net45+win8+wp8+wpa81;</PackageTargetFallback> | ||
<IsPackable>false</IsPackable> | ||
<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies> | ||
</PropertyGroup> | ||
|
||
<ItemGroup> | ||
<PackageReference Include="CodeGeneration.Roslyn" Version="$(CodeGenerationRoslynVersion)" /> | ||
</ItemGroup> | ||
</Project> |
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<Project Sdk="Microsoft.NET.Sdk"> | ||
<PropertyGroup> | ||
<TargetFrameworks>net40;netstandard1.0</TargetFrameworks> | ||
<SignAssembly>true</SignAssembly> | ||
<AssemblyOriginatorKeyFile>..\libgit2sharp.snk</AssemblyOriginatorKeyFile> | ||
<IsPackable>false</IsPackable> | ||
</PropertyGroup> | ||
|
||
<ItemGroup> | ||
<PackageReference Include="CodeGeneration.Roslyn.Attributes" Version="$(CodeGenerationRoslynVersion)" /> | ||
</ItemGroup> | ||
</Project> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Diagnostics; | ||
using System.Text; | ||
|
||
namespace LibGit2Sharp | ||
{ | ||
[AttributeUsage(AttributeTargets.Parameter | AttributeTargets.ReturnValue, AllowMultiple = false)] | ||
[Conditional("CodeGeneration")] | ||
public class CustomMarshalerAttribute : Attribute | ||
{ | ||
/// <summary> | ||
/// Initializes a new instance of the <see cref="CustomMarshalerAttribute"/> class. | ||
/// </summary> | ||
/// <param name="customMarshaler">The type that derives from ICustomMarshaler.</param> | ||
/// <param name="friendlyType">The type to expose in the generated overload.</param> | ||
public CustomMarshalerAttribute(Type customMarshaler, Type friendlyType) | ||
{ | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
using System; | ||
using System.Diagnostics; | ||
using CodeGeneration.Roslyn; | ||
|
||
namespace LibGit2Sharp | ||
{ | ||
/// <summary> | ||
/// Causes generation of an overload of a P/Invoke method that has a more friendly signature. | ||
/// </summary> | ||
[AttributeUsage(AttributeTargets.Class, AllowMultiple = true)] | ||
[CodeGenerationAttribute("CodeGeneration.OfferFriendlyInteropOverloadsGenerator, CodeGeneration, Version=" + ThisAssembly.AssemblyVersion + ", Culture=neutral, PublicKeyToken=null")] | ||
[Conditional("CodeGeneration")] | ||
public class OfferFriendlyInteropOverloadsAttribute : Attribute | ||
{ | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<Project> | ||
<PropertyGroup> | ||
<OutputPath>$(MSBuildThisFileDirectory)bin\$(MSBuildProjectName)\$(Configuration)\</OutputPath> | ||
<BaseIntermediateOutputPath>$(MSBuildThisFileDirectory)obj\$(MSBuildProjectName)\</BaseIntermediateOutputPath> | ||
|
||
<CodeGenerationRoslynVersion>0.3.13-gfce1c8ba1e</CodeGenerationRoslynVersion> | ||
</PropertyGroup> | ||
|
||
<ItemGroup> | ||
<PackageReference Include="Nerdbank.GitVersioning" Version="1.6.25" PrivateAssets="all" /> | ||
</ItemGroup> | ||
</Project> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<Project> | ||
<PropertyGroup> | ||
<PublicSign Condition=" '$(AssemblyOriginatorKeyFile)' != '' and '$(OS)' != 'Windows_NT' ">true</PublicSign> | ||
</PropertyGroup> | ||
</Project> |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we doing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the git "height" can be calculated during the build, as it makes up part of the version number of the nuget package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, that's clever.
Apparently Travis doesn't have an option to just do a regular clone, which is a pity, since a shallow clone followed by unshallowing it is crazy expensive compared to just doing a regular clone in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I couldn't find a way to disable their shallow fetching, so this seemed like the best workaround.