-
Notifications
You must be signed in to change notification settings - Fork 899
Target .NET Standard 1.3 #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target .NET Standard 1.3 #1318
Conversation
This is in preparation for a portable project alongside the net40 one.
Plenty of compiler errors at this point.
Before this, it only existed in debug configuration.
RecurseSubmodulesException claimed to be serializable but was missing a deserializing constructor so I added that.
This will keep the maintenance cost of updating the version to just one file (one line, in fact) instead of the 3 lines it was before, and the dozens of lines it would become with the increase in number of projects that may occur in the near future.
And fix up build breaks it introduces
Yes, that makes sense. |
So my thought process on this was, since we don't have any analyzers in the native binaries package, there wouldn't be any harm dropping that from the list. I can't currently think of a scenario where we'd add an analyzer, but if we did, who's to say if it would be just for LibGit2Sharp, or all consumers? Ultimately, regardless of which option we choose, there's a chance it would have to be revisited should the native binaries package actually add an analyzer, so it made sense to me to only include things in the list that we know for sure we don't want downstream consumers to see. |
That's fine. It was just a nit anyway, and my motivation for it was to maintain the default nuget include/exclude behaviors unless we had an explicit reason to do otherwise. |
I'd like to do a release but we're waiting on finalizing some things in libgit2. I'm going to branch for the upcoming release so that we can merge this into master. |
@ethomson Do you have a link to any issue on things being finalized in libgit2? |
Is there any indication when this will be available? |
Okay - v0.24 is released based on libgit2 v0.26. Thanks for your patience. @AArnott would you mind a final update just to fix the merge conflicts (which I think should be minor, but if not, then please let me know and I'm happy to resolve them), and rev the version number, and then we'll merge this? |
with pleasure... |
Validation complete. |
This is great and thanks for your work. Any idea when 0.25 will be available on NuGet? |
@jaredcnance No specific ETA yet, but hoping to have available "Soon". |
(tm) |
Adds .NET Core support (by way of targeting .NET Standard 1.3). .NET Framework 4.0 is still a target, but we
leverage VS2017 .NET SDK projects to multi-target both net40 and netstandard1.3 to maximize reach and enable libgit2sharp to work across platforms by way of .NET Core.
Closes #1293