Rename replace_axes as set_axes + update doc of rename method #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdementen
reviewed
Mar 13, 2017
larray/core.py
Outdated
| @@ -4319,6 +4328,10 @@ def rename(self, renames=None, to=None, **kwargs): | |||
| nat2\\sex2 | M | F | |||
| BE | 0 | 1 | |||
| FO | 2 | 3 | |||
| >>> arr.rename({'nat': 'nat2', 'sex': 'sex2'}) | |||
There was a problem hiding this comment.
duh? this is the same as the previous example?
There was a problem hiding this comment.
It was to test the inplace flag. I failded to properly clean the examples.
| @@ -3905,7 +3905,7 @@ def __init__(self, | |||
| raise ValueError("length of axes %s does not match " | |||
| "data shape %s" % (axes.shape, data.shape)) | |||
|
|
|||
| # Because __getattr__ and __setattr__ have been rewritten | |||
| # Because __getattr__ and __setattr__ have been overridden | |||
There was a problem hiding this comment.
even though it is indeed the case, __setattr__ should actually not be overridden (ever since we changed __getattr__ to return axes). It might be better to fix that in a separate PR though, because most (all?) object.__setattr__ could/should be replaced.
larray/core.py
Outdated
| @@ -3976,28 +3973,37 @@ def replace_axes(self, axes_to_replace=None, new_axis=None, **kwargs): | |||
| a1 | 3 | 4 | 5 | |||
| >>> row = Axis('row', ['r0', 'r1']) | |||
| >>> column = Axis('column', ['c0', 'c1', 'c2']) | |||
| >>> arr.replace_axes(x.a, row) | |||
|
|
|||
| Replace one axis (expect 2 arguments) | |||
There was a problem hiding this comment.
the "expect 2 arguments" part is a bit strange. who should expect? the function or the user? => replace by somethng like:
Replace one axis (the second argument is required when using this syntax)
fix larray-project#133 :Rename replace_axes as set_axes. Add inplace flag to set_axes and rename methods
alixdamman
force-pushed
the
rename_replace_axes
branch
from
a0bd8c8 to
a139f99
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #121 : Update docstring of set_labels.
fix #133 : Rename replace_axes as set_axes.
Add inplace flag to set_axes and rename methods