fix: trigger pruning on tick #1086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpaulucci
reviewed
May 21, 2024
| last_finalized_key = slot |> root_by_slot_key() | ||
|
|
||
| with {:ok, it} <- Db.iterate(), | ||
| {:ok, @stateslot_prefix <> _slot, _value} <- | ||
| Exleveldb.iterator_move(it, last_finalized_key), | ||
| {:ok, slots_to_remove} <- get_slots_to_remove(it), | ||
| :ok <- Exleveldb.iterator_close(it) do | ||
| slots_to_remove |> Enum.map(&remove_by_slot/1) | ||
| slots_to_remove |> Enum.each(&remove_by_slot/1) | ||
| Logger.info("[StateDb] Pruning finished. #{length(slots_to_remove)} slots removed.") | ||
| end | ||
| end | ||
|
|
||
| defp get_slots_to_remove(slots_to_remove \\ [], iterator) do |
There was a problem hiding this comment.
can you add typespec here? I am confused if slots are integers or binaries
There was a problem hiding this comment.
Maybe I can create an issue to refactor this for clarity.
MegaRedHand
reviewed
May 21, 2024
| end | ||
| end | ||
|
|
||
| defp get_slots_to_remove(slots_to_remove \\ [], iterator) do | ||
| case Exleveldb.iterator_move(iterator, :prev) do | ||
| {:ok, @stateslot_prefix <> slot, _root} -> | ||
| [slot | slots_to_remove] |> get_slots_to_remove(iterator) | ||
| [slot |> :binary.decode_unsigned() | slots_to_remove] |> get_slots_to_remove(iterator) |
There was a problem hiding this comment.
You can match this here by doing:
{:ok, @stateslot_prefix <> <<slot::unsigned-size(64)>>, _root} ->
mpaulucci
reviewed
May 21, 2024
| end | ||
| end | ||
|
|
||
| @spec get_slots_to_remove(list(), :eleveldb.itr_ref()) :: {:ok, list(non_neg_integer())} |
mpaulucci
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State pruning was not being triggered because checkpoint updates were occurring within the
on_tickfunction, while only updates within theon_blockfunction had been considered.