fix: trigger pruning on tick (#1086)

Author: avilagaston9

lib/lambda_ethereum_consensus/fork_choice/fork_choice.ex

@@ -89,12 +89,7 @@ defmodule LambdaEthereumConsensus.ForkChoice do
 
         %Store{finalized_checkpoint: new_finalized_checkpoint} = new_store
 
-        if last_finalized_checkpoint.epoch < new_finalized_checkpoint.epoch do
-          new_finalized_slot =
-            new_finalized_checkpoint.epoch * ChainSpec.get("SLOTS_PER_EPOCH")
-
-          Task.async(StateDb, :prune_states_older_than, [new_finalized_slot])
-        end
+        prune_old_states(last_finalized_checkpoint.epoch, new_finalized_checkpoint.epoch)
 
         GenServer.cast(from, {:block_processed, block_root, true})
         {:noreply, new_store}
@@ -139,7 +134,11 @@ defmodule LambdaEthereumConsensus.ForkChoice do
 
   @impl GenServer
   def handle_cast({:on_tick, time}, store) do
+    %Store{finalized_checkpoint: last_finalized_checkpoint} = store
+
     new_store = Handlers.on_tick(store, time)
+    %Store{finalized_checkpoint: new_finalized_checkpoint} = new_store
+    prune_old_states(last_finalized_checkpoint.epoch, new_finalized_checkpoint.epoch)
     {:noreply, new_store}
   end
 
@@ -152,6 +151,15 @@ defmodule LambdaEthereumConsensus.ForkChoice do
   ### Private Functions
   ##########################
 
+  def prune_old_states(last_finalized_epoch, new_finalized_epoch) do
+    if last_finalized_epoch < new_finalized_epoch do
+      new_finalized_slot =
+        new_finalized_epoch * ChainSpec.get("SLOTS_PER_EPOCH")
+
+      Task.async(StateDb, :prune_states_older_than, [new_finalized_slot])
+    end
+  end
+
   @spec apply_handler(any(), any(), any()) :: any()
   def apply_handler(iter, state, handler) do
     iter

lib/lambda_ethereum_consensus/store/state_db.ex

@@ -2,6 +2,7 @@ defmodule LambdaEthereumConsensus.Store.StateDb do
   @moduledoc """
   Beacon node state storage.
   """
+  require Logger
   alias LambdaEthereumConsensus.Store.Db
   alias LambdaEthereumConsensus.Store.Utils
   alias Types.BeaconState
@@ -30,30 +31,35 @@ defmodule LambdaEthereumConsensus.Store.StateDb do
     Db.put(slothash_key_block, block_root)
   end
 
+  @spec prune_states_older_than(non_neg_integer()) :: :ok | {:error, String.t()} | :not_found
   def prune_states_older_than(slot) do
+    Logger.info("[StateDb] Pruning started.", slot: slot)
     last_finalized_key = slot |> root_by_slot_key()
 
     with {:ok, it} <- Db.iterate(),
          {:ok, @stateslot_prefix <> _slot, _value} <-
            Exleveldb.iterator_move(it, last_finalized_key),
          {:ok, slots_to_remove} <- get_slots_to_remove(it),
          :ok <- Exleveldb.iterator_close(it) do
-      slots_to_remove |> Enum.map(&remove_by_slot/1)
+      slots_to_remove |> Enum.each(&remove_state_by_slot/1)
+      Logger.info("[StateDb] Pruning finished. #{length(slots_to_remove)} slots removed.")
     end
   end
 
+  @spec get_slots_to_remove(list(non_neg_integer()), :eleveldb.itr_ref()) ::
+          {:ok, list(non_neg_integer())}
   defp get_slots_to_remove(slots_to_remove \\ [], iterator) do
     case Exleveldb.iterator_move(iterator, :prev) do
-      {:ok, @stateslot_prefix <> slot, _root} ->
+      {:ok, @stateslot_prefix <> <<slot::unsigned-size(64)>>, _root} ->
         [slot | slots_to_remove] |> get_slots_to_remove(iterator)
 
       _ ->
         {:ok, slots_to_remove}
     end
   end
 
-  defp remove_by_slot(binary_slot) do
-    slot = :binary.decode_unsigned(binary_slot)
+  @spec remove_state_by_slot(non_neg_integer()) :: :ok | :not_found
+  defp remove_state_by_slot(slot) do
     key_slot = root_by_slot_key(slot)
 
     with {:ok, block_root} <- Db.get(key_slot),