RFC - Support WebSockets with channels #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The port forward, attach and exec commands all return WebSockets which contain data in different channels.
This PR adds code which can take such as
WebSocket
and decompose (de-multiplex) it into differentStreams
.A client could use this API like this:
From a design point of view, the
StreamDemuxer
class has aClientLoop
which reads all the data of theWebSocket
and stores it in individualByteBuffers
- one for each channel.For each channel, there's a corresponding
DemuxedStream
which reads the bytes from theByteBuffer
class. So you get a producer-consumer implementation.As outlined in the other issue, I'm not entirely satisfied with this implementation because of the buffering, but it may be a good first start.
Opening the PR mainly to get your feedback, let me know what you think!