Add convenient model extensions

[admilazz]

This change adds a many useful model extension methods that make the Kubernetes client smoother and more concise to use. This change helps address issue #390 .

• Metadata is inlined, so instead of o.Metadata.X, you can use o.X(). Examples:

  o.Metadata?.Name -> o.Name()
  o.Metadata?.NamespaceProperty -> o.Namespace()
  ... etc ...
  

• Managing labels and annotations. Examples for labels:

  string value = null;
  if(o.Metadata.Labels != null) o.Metadata.Labels.TryGetValue(key, out value)
  

  becomes

  o.GetLabel(key)
  

  Similarly,

  if(o.Metadata == null) o.Metadata = new V1ObjectMeta();
  if(o.Metadata.Labels == null) o.Metadata.Labels = new Dictionary<string,string>();
  o.Metadata.Labels[key] = value;
  

  becomes

  o.SetLabel(key, value)
  

• Managing owner and object references

  • o.AddOwnerReference(ownerRef) // adds an owner reference
  • o.CreateOwnerReference(...) // create an owner reference to o
  • o.FindOwnerReference(owner) // finds and returns the reference to 'owner', if any
  • o.GetController() // gets the reference to the owner that controls the resource
  • o.GetObjectReference() // creates an object reference to o
  • ownerRef.Matches(o) // does ownerRef refer to o?
  • objRef.Matches(o) // does objRef refer to o?
  • ...

• And some other small things.

The pull request depends on (and includes) the IKubernetesObject<T> PR I submitted earlier: #404 The only changes in this PR specifically belong to the ModelExtensions.cs file. (I'm not sure how best to represent that in a PR...)

[admilazz]

/assign @krabhishek8260

[brendandburns]

I'll wait for this PR to be rebased on the other one when it merges.

[admilazz]

I'll wait for this PR to be rebased on the other one when it merges.

Okay, I think that's done.

[admilazz]

I'm pretty sure that test failure is unrelated to my changes. Any way to rerun them?

[macsux]

I'm pretty sure that test failure is unrelated to my changes. Any way to rerun them?
Just add another commit or do what I do: reword the commit and force push it, it will trigger rebuild

[tg123]

I'm pretty sure that test failure is unrelated to my changes. Any way to rerun them?
Just add another commit or do what I do: reword the commit and force push it, it will trigger rebuild

re-triggered

[admilazz]

re-triggered

Magic. But now it needs a rebase anyway. :-P

[tg123]

re-triggered

Magic. But now it needs a rebase anyway. :-P

there is a re-run button on top-right of console output
https://github.com/kubernetes-client/csharp/pull/405/checks?check_run_id=596493449

[macsux]

there is a re-run button on top-right of console output

I don't have this button. Maybe you have more permissions then I do

[brendandburns]

Couple more comments.

[admilazz]

Couple more comments.

Addressed.

[macsux]

Tried using this as part of controller codebase. Very convenient - hope it gets merged in soon. One method I recommend you add that I found wanting: AddOwnerReference(IKubernetesObject)

[admilazz]

Tried using this as part of controller codebase. Very convenient - hope it gets merged in soon. One method I recommend you add that I found wanting: AddOwnerReference(IKubernetesObject)

I had methods for creating object and owner references but removed them because my implementation relied on the KubernetesScheme class which was part of the fluent API PR. (I could easily implement them a different way here, but then I wouldn't be able to have the KubernetesScheme-based versions in the fluent API).

Anyway, AFAIK think this PR is ready to merge if people want it...

[macsux]

Imo you should reopen that pr, just isolate it into own assembly like I did with informers

…

On Sat., Apr. 25, 2020, 6:17 p.m. admilazz, ***@***.***> wrote: Tried using this as part of controller codebase. Very convenient - hope it gets merged in soon. One method I recommend you add that I found wanting: AddOwnerReference(IKubernetesObject) I had methods for creating object and owner references but removed them because my implementation relied on the KubernetesScheme class which was part of the fluent API PR. (I could easily implement them a different way here, but then I wouldn't be able to have the KubernetesScheme-based versions in the fluent API). Anyay, AFAIK think this PR is ready to merge if people want it... — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#405 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAINFWGVD56UAZSM6MBXOCLRONOP5ANCNFSM4MDR6Y3Q> .

[brendandburns]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: admilazz, brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment