-
Notifications
You must be signed in to change notification settings - Fork 305
Add IKubernetesObject<TMetadata> #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IKubernetesObject<TMetadata> #404
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @admilazz! |
Hey prow robot, recheck my CLA... |
/assign @krabhishek8260 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: admilazz, brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
With IKubernetesObject and IMetadata<T> being completely separate, there is no single type that I can use to capture them both, which leads to a great proliferation of generics with type constraints, e.g.
Every place where such an object is passed or returned must be made generic and decorated with type constraints. It'd be helpful to have an interface that encapsulates the combination of the above.
This change adds such an interface and addresses issue #393 .