Skip to content
This repository was archived by the owner on Apr 28, 2020. It is now read-only.

Remove unneeded spaces and commas from Json5Object.ToJson5String #13

Merged
merged 2 commits into from
Aug 25, 2018

Conversation

mcraiha
Copy link
Contributor

@mcraiha mcraiha commented Aug 25, 2018

This fixes at least following tests:
UnquotedPropertyNamesTest
EmptyStringPropertyNamesTest
SpecialCharacterPropertyNamesTest
UnicodePropertyNamesTest
MultiplePropertiesTest
NestedObjectsTest

This fixes at least following tests:
UnquotedPropertyNamesTest
EmptyStringPropertyNamesTest
SpecialCharacterPropertyNamesTest
UnicodePropertyNamesTest
MultiplePropertiesTest
NestedObjectsTest
@jordanbtucker
Copy link
Member

Similar to #10, I'm going to merge this, but it may be replaced by future code that is based on how JSON5.stringify handles objects, which is based on how ES6 stringify handles objects.

@jordanbtucker jordanbtucker self-assigned this Aug 25, 2018
@jordanbtucker
Copy link
Member

Actually, I just noticed that this contains the same commit as #12. So that's holding it up until I know what that is.

@jordanbtucker jordanbtucker merged commit 89aa592 into json5:master Aug 25, 2018
@mcraiha mcraiha deleted the remove-unneeded-spaces branch August 26, 2018 06:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants