This repository was archived by the owner on Apr 28, 2020. It is now read-only.
Parse doubles with CultureInfo.InvariantCulture #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from master
This fixes following tests with certain cultures: LeadingZeroesTest SignedNumbersTest LeadingDecimalPointsTest FractionalNumbersTest ExponentsTest
|
The code looks good, but what is the first commit for? |
This was referenced Aug 25, 2018
|
Sorry about cc51278, it seems to come from my end because I used GitHub browser interface for merging the changes from json5/json5-dotnet to my fork. I can redo these branches from clean slate if it is better for you. |
|
Oh, I just realized that it's a PR in your fork, not this one. I bet if I squash these commits it won't show up in history. Trying to keep the history clean. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes following tests with certain cultures:
LeadingZeroesTest
SignedNumbersTest
LeadingDecimalPointsTest
FractionalNumbersTest
ExponentsTest