Skip to content

Merge master (v5.1.0) into openapi branch #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 60 commits into from
Dec 14, 2022
Merged

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Nov 8, 2022

Aside from the merge itself:

  • Updated calls to ArgumentGuard to remove the nameof() parameter
  • Fixed Microsoft.SourceLink.GitHub / SauceControl.InheritDoc in OpenAPI project files that produce NuGet packages
  • Fixup constraint in tests to require TestableDbContext instead of DbContext

QUALITY CHECKLIST

bkoelman and others added 30 commits September 9, 2022 14:36
…e the fully qualified type names of the conflicting controllers
…e members to Hint level, because they tend to cause backwards-compatibility issues in publicly exposed signatures
…o (git handles this automatically if omitted)
…inux

Update to latest Resharper version (and related formatting improvements)
Multi-target Annotations against .NET Standard 1.0
…rror

Improve error message when duplicate controllers found
Co-authored-by: Maurits Moeys <maurits.moeys@gmail.com>
…'t need to edit appsettings.json when debugging
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #1209 (ec52cf7) into openapi (375a0ed) will increase coverage by 0.04%.
The diff coverage is 98.45%.

@@             Coverage Diff             @@
##           openapi    #1209      +/-   ##
===========================================
+ Coverage    92.24%   92.29%   +0.04%     
===========================================
  Files          303      304       +1     
  Lines         8774     8866      +92     
===========================================
+ Hits          8094     8183      +89     
- Misses         680      683       +3     
Impacted Files Coverage Δ
...Annotations/Resources/Annotations/AttrAttribute.cs 90.00% <ø> (ø)
.../Resources/Annotations/ResourceAttribute.shared.cs 100.00% <ø> (ø)
...urces/Annotations/ResourceLinksAttribute.shared.cs 100.00% <ø> (ø)
...ourceGenerators/TypeWithAttributeSyntaxReceiver.cs 100.00% <ø> (ø)
...ation/JsonConverters/WriteOnlyDocumentConverter.cs 91.66% <ø> (ø)
...Converters/WriteOnlyRelationshipObjectConverter.cs 81.25% <ø> (ø)
...sonApiDotNetCore/Serialization/Objects/Document.cs 100.00% <ø> (ø)
...nApiDotNetCore/Serialization/Objects/ErrorLinks.cs 100.00% <ø> (ø)
...ApiDotNetCore/Serialization/Objects/ErrorObject.cs 95.00% <ø> (ø)
...ApiDotNetCore/Serialization/Objects/ErrorSource.cs 100.00% <ø> (ø)
... and 193 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bkoelman bkoelman changed the base branch from master to openapi November 9, 2022 01:49
@bkoelman bkoelman marked this pull request as ready for review November 9, 2022 12:46
@bkoelman bkoelman requested a review from maurei November 9, 2022 12:46
bkoelman and others added 18 commits November 11, 2022 11:54
…ior.ClientSetNull to DeleteBehavior.SetNull

This improves speed and reduces the number of errors logged by the PostgreSQL server when running tests, because we no longer need the "truncate table cascade" fallback in DbContextExtensions.
Update to latest version of regitlint
@bkoelman
Copy link
Member Author

bkoelman commented Dec 14, 2022

@maurei as part of the bits you merged today, the changes from #1218 should be propagated to the OpenAPI projects. Specifically:

  • Remove xunit.runner.json files on disk and any references to them in .csproj files.
  • In *DbContext classes that override OnModelCreating, call base.OnModelCreating(builder) at the end of the method.

@maurei
Copy link
Member

maurei commented Dec 14, 2022

Acknowledged!

@maurei maurei merged commit 4392777 into openapi Dec 14, 2022
@maurei maurei deleted the merge-v5.1-into-openapi branch December 14, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants