-
-
Notifications
You must be signed in to change notification settings - Fork 158
Update to latest Resharper version (and related formatting improvements) #1191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4173c78
to
9b96a42
Compare
Codecov Report
@@ Coverage Diff @@
## master #1191 +/- ##
==========================================
+ Coverage 92.59% 92.61% +0.02%
==========================================
Files 242 242
Lines 7706 7701 -5
==========================================
- Hits 7135 7132 -3
+ Misses 571 569 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
68c4aa3
to
edd7cef
Compare
4cea396
to
e9dbea8
Compare
@maurei Can you verify if the reformat works properly in Rider for macOS?
|
7aa39c3
to
befa644
Compare
…e members to Hint level, because they tend to cause backwards-compatibility issues in publicly exposed signatures
…gumentExpressionAttribute instead
…o (git handles this automatically if omitted)
befa644
to
292fb45
Compare
Confirmed: it works as desired. |
maurei
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to the latest Resharper version. However, the InspectCode/CleanupCode steps are being skipped in cibuild on Linux due to this bug.
Part of this PR is improved formatting support:
Additionally, this PR simplifies argument null checks in code.
As usual, see the individual commits for details.
QUALITY CHECKLIST