Skip to content

Merge master into openapi #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 26, 2022
Merged

Merge master into openapi #1163

merged 9 commits into from
Jun 26, 2022

Conversation

bkoelman
Copy link
Member

No description provided.

* Removed workaround for dotnet/roslyn#55802. The bug has been fixed in VS 2022 v17.2.

* Package updates (in non-breaking fashion)
…e field from its OnApplySort lambda. Where we used to special-case for Identifiable.Id, we now always use the expression type for resource graph lookups. This is safe because its not possible in C# to remove base members. The value of memberExpression.Expression is null on static member access, which is unlikely to occur in sort lambdas.
…type-hierarchy

Fixed crash in sort lambda from generic resource definition
@bkoelman bkoelman changed the base branch from master to openapi June 24, 2022 01:52
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #1163 (8c7e1a8) into openapi (ae81441) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           openapi    #1163      +/-   ##
===========================================
- Coverage    92.24%   92.24%   -0.01%     
===========================================
  Files          302      302              
  Lines         8770     8768       -2     
===========================================
- Hits          8090     8088       -2     
  Misses         680      680              
Impacted Files Coverage Δ
...tations/Resources/Annotations/ResourceAttribute.cs 100.00% <ø> (ø)
...Core.SourceGenerators/ControllerSourceGenerator.cs 98.46% <ø> (ø)
...tCore/Configuration/ServiceCollectionExtensions.cs 100.00% <ø> (ø)
...sonApiDotNetCore/Diagnostics/CascadingCodeTimer.cs 0.00% <ø> (ø)
.../Queries/Expressions/QueryableHandlerExpression.cs 41.17% <ø> (ø)
...Core/Repositories/EntityFrameworkCoreRepository.cs 99.29% <ø> (ø)
...NetCore/Resources/SortExpressionLambdaConverter.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae81441...8c7e1a8. Read the comment docs.

@bkoelman bkoelman merged commit f65b7fe into openapi Jun 26, 2022
@bkoelman bkoelman deleted the merge-master-into-openapi branch June 26, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant