Skip to content

Removed workaround for debugging source generators #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2022

Conversation

bkoelman
Copy link
Member

Removed workaround for dotnet/roslyn#55802. The bug has been fixed in VS 2022 v17.2.

Note this PR solely affects debugging the source generator logic in the JsonApiDotNetCore codebase. This PR is unrelated to consumers of JsonApiDotNetCore that are debugging their source-generated controllers.

QUALITY CHECKLIST

  • Changes implemented in code
  • Complies with our contributing guidelines
  • N/A: Adapted tests
  • N/A: Documentation updated

@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #1155 (314a1e4) into master (bba90e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1155   +/-   ##
=======================================
  Coverage   92.58%   92.58%           
=======================================
  Files         241      241           
  Lines        7702     7702           
=======================================
  Hits         7131     7131           
  Misses        571      571           
Impacted Files Coverage Δ
...tations/Resources/Annotations/ResourceAttribute.cs 100.00% <ø> (ø)
...Core.SourceGenerators/ControllerSourceGenerator.cs 98.46% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba90e5...314a1e4. Read the comment docs.

@bkoelman bkoelman merged commit 9e0fed8 into master May 21, 2022
@bkoelman bkoelman deleted the remove-sourcegen-workaround branch May 21, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant