Skip to content

Upgrade Wildfly Swarm to Thorntail #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

juangon
Copy link
Contributor

@juangon juangon commented Jan 18, 2019

Hi!

I upgraded these tests so they can pass with new Thorntail versions.

Want to highlight 2 changes made and their reasons:

@juangon
Copy link
Contributor Author

juangon commented Jan 18, 2019

/cc @Ladicek

@Ladicek
Copy link

Ladicek commented Jan 18, 2019

Looking good to me.

I'm sure we talked about this before, but can't remember, so I'll ask again: wouldn't enabling thorntail.microprofile.fault-tolerance.synchronous-circuit-breaker make sure that the circuit breaker will open after that exact number of requests?

@juangon
Copy link
Contributor Author

juangon commented Jan 18, 2019

Yes, I tested that and didn't work: #5 (comment)

@arjantijms arjantijms merged commit e8500d2 into javaee-samples:master Jan 18, 2019
@juangon juangon mentioned this pull request Jan 21, 2019
@juangon
Copy link
Contributor Author

juangon commented Jan 23, 2019

@arjantijms I wonder if there is any plan to add microprofile 2.x samples repository, using the same approach made in microprofile-1.2-samples and microprofile-1.4-samples.

Thanks!

@arjantijms
Copy link
Contributor

@juangon absolutely!

Just need some time ;)

@juangon
Copy link
Contributor Author

juangon commented Jan 23, 2019

Thanks @arjantijms ! I think you are doing a great job with these repositories BTW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants