Upgrade Wildfly Swarm to Thorntail

[juangon]

Hi!

I upgraded these tests so they can pass with new Thorntail versions.

Want to highlight 2 changes made and their reasons:

• Added better ExecutionException check. As stated in https://github.com/eclipse/microprofile-fault-tolerance/blob/master/spec/src/main/asciidoc/asynchronous.asciidoc#exception-handling, ExecutionException can wrap the exceptions from Bulkhead, Timeout, etc.
• In circuitbreaker tests, I added 2 changes:
  • Added one more iteration to open circuit. This was clarified as part of this: Inconsistency between CircuitBreaker.failureRatio() javadoc and spec example microprofile/microprofile-fault-tolerance#341 (opened by @mkouba)
  • As there could be problems when using concurrent request (it may happen that circuit isn't open when throwing the exact number of request to get expected number of requests) I changed requests to be sequential by using newSingleThread executor.

[Ladicek]

Shouldn't be merged now then.

[juangon]

Ok better wait to 2.3.0.Final right?

[Ladicek]

Yea, if it doesn't work with 2.2.1.Final, then we need to wait for 2.3.0.Final.

[Ladicek]

As there could be problems when using concurrent request (it may happen that circuit isn't open when throwing the exact number of request to get expected number of requests) I changed requests to be sequential by using newSingleThread executor.

I think you should enable thorntail.microprofile.fault-tolerance.synchronous-circuit-breaker -- that enables 100% compliant behavior at the expense of probably worse performance.

[juangon]

As there could be problems when using concurrent request (it may happen that circuit isn't open when throwing the exact number of request to get expected number of requests) I changed requests to be sequential by using newSingleThread executor.

I think you should enable thorntail.microprofile.fault-tolerance.synchronous-circuit-breaker -- that enables 100% compliant behavior at the expense of probably worse performance.

It's enabled by default. I enabled it just in case and doesn't work.

[juangon]

I am gonna send PR whenever 2.3.0.Final is out so we don't use SNAPSHOT versions.

Thanks @Ladicek for the review!

[arjantijms]

Thanks @Ladicek indeed!

@juangon Will be looking forward to your next PR, thx!

[juangon]

Resent here: #7