Skip to content

support GHC 9.4.4 #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 24, 2023
Merged

support GHC 9.4.4 #1822

merged 7 commits into from
Jan 24, 2023

Conversation

peterbecich
Copy link
Contributor

checked with

 nix-build scripts/check-compiler-materialization --argstr compiler-nix-name ghc944

@TeofilC
Copy link
Contributor

TeofilC commented Jan 3, 2023

I'm getting these warnings when using this MR:

trace: WARNING: No materialized dummy-ghc-data.  mkdir /nix/store/awz5pj0w14x7grvvc29caflkdlipr4ak-source/materialized/dummy-ghc/ghc-9.4.4-x86_64-linux
trace: WARNING: No materialized dummy-ghc-data.  mkdir /nix/store/awz5pj0w14x7grvvc29caflkdlipr4ak-source/materialized/dummy-ghc/ghc-9.4.4-x86_64-linux

I guess that script must not check for them

@peterbecich peterbecich mentioned this pull request Jan 12, 2023
@ken-scarf
Copy link

What's the usual step for updating ghc? Is it updating modules/component-driver.nix and overlays/bootstrap.nix, then materializing it?

@peterbecich
Copy link
Contributor Author

peterbecich commented Jan 21, 2023

@ken-scarf , yes I think that's all that's needed, maybe we should add component-driver.nix here: https://input-output-hk.github.io/haskell.nix/dev/adding-new-ghc.html

@peterbecich
Copy link
Contributor Author

Can someone look at this if convenient? It may assist with GHC 9.4.4

iserv-proxy missing for GHC 9.4.3 #1807

I think the fix may be here:

} // final.lib.optionalAttrs (builtins.compareVersions ghcVersion "9.4" < 0) {
# The version of `Win32` that comes with ghc 9.4 (2.12.0.0) is older
# than the one in hackage. Including it causes `cabal configure` to fail.
Win32 = "libraries/Win32";
# As of GHC 9.4 this has been split out of the GHC repo and
# is now in the iserv-proxy flake input
iserv-proxy = "utils/iserv-proxy";

@peterbecich
Copy link
Contributor Author

I'm not sure what to do about #1822 (comment)

@TeofilC
Copy link
Contributor

TeofilC commented Jan 21, 2023

I am optimistic that the iserv-proxy issue might be fixed by #1814 but I'm not sure -- at least it looks like it touches code to do with iserv-proxy

@TeofilC
Copy link
Contributor

TeofilC commented Jan 21, 2023

I've made a commit to add the materialised dummy ghc for x86_64-linux here: TeofilC@f0e3cad

I'll see if I can generate the other ones but I'm not sure if I'll be able to do it on my machine

@hamishmack hamishmack merged commit e83ef3d into input-output-hk:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants