Skip to content

Add nixpkgs-2105 #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 23, 2021
Merged

Add nixpkgs-2105 #1133

merged 9 commits into from
Jun 23, 2021

Conversation

akrmn
Copy link
Contributor

@akrmn akrmn commented Jun 7, 2021

Given the recent release of nixpkgs-2105 (https://github.com/NixOS/nixpkgs/releases/tag/21.05) I thought this was in order :) I based my additions on #1025, but please let me know if there's anything else needed.

@JackKelly-Bellroy
Copy link
Contributor

It would be great to see this come through, as 21.05 includes some cross-compilation fixes for openssl on non-linux build machines.

@michaelpj
Copy link
Collaborator

Probably we need to do this from a branch in the main repo, I don't think Hydra will build this and we need to do that to see if it works!

@akrmn
Copy link
Contributor Author

akrmn commented Jun 8, 2021

One thing I just noticed is that GHC 8.10.4 isn't working on macOS+nixpkgs-2105 (it does work on nixpkgs-unstable), nix-shell fails with https://gitlab.haskell.org/ghc/ghc/-/issues/19655. This was resolved on GHC 8.10.5, so maybe we should add support for that before adding nixpkgs-2105 (?)

@michaelpj
Copy link
Collaborator

We still have 20.09, so that's okay. We can mark things as broken for now. But yeah, doing this sort of update involves a lot of waiting to see which things are broken and fussing with the conditional logic, unfortunately.

@@ -2,6 +2,8 @@ final: prev: let
# GHCJS currently requires an old version of emscripten. Overriding to build the older version doesn't
# work straightforwardly on 20.09 anymore, so we use an ugly hack and pull emscripten from 20.03.
# In future, we'll just fix GHCJS to work with the newer emscripten.

# Not sure what to do here - akrmn
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @michaelpj, I think I got rid of all occurrences of nixpkgs-2003 or R2003, except for this one. The comment above mine is a bit worrying.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is a bit worrying. I also don't know what to do about this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to keep a nixpkgs-2003 pin for now

@domenkozar
Copy link
Contributor

Would be great to have this in for LTS-18.0

@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request Jun 22, 2021
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 22, 2021

try

Timed out.

@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request Jun 22, 2021
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 22, 2021

try

Build failed:

@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request Jun 22, 2021
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 22, 2021

try

Build failed:

@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request Jun 22, 2021
@hamishmack
Copy link
Collaborator

bors try-

@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request Jun 22, 2021
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 22, 2021

try

Timed out.

@hamishmack
Copy link
Collaborator

hydra did finish ok in the end.

@hamishmack hamishmack merged commit 2b842f2 into input-output-hk:master Jun 23, 2021
booniepepper pushed a commit to booniepepper/haskell.nix that referenced this pull request Feb 4, 2022
* Add nixpkgs-2105

* [WIP] Drop nixpkgs-2003

* Update all the nixpkgs pins

* Default to nixpkgs-2009 for build.nix

* Update individual jobs to nixpkgs 2105

Co-authored-by: Hamish Mackenzie <Hamish.K.Mackenzie@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants