Skip to content

Add nixpkgs-unstable #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 3, 2021
Merged

Add nixpkgs-unstable #1025

merged 9 commits into from
Feb 3, 2021

Conversation

hamishmack
Copy link
Collaborator

No description provided.

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Feb 1, 2021
@hamishmack
Copy link
Collaborator Author

bors try-

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Feb 1, 2021
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 1, 2021

try

Timed out.

@hamishmack hamishmack added the hydra-do-build Enables PR jobset in Hydra label Feb 3, 2021
@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Feb 3, 2021
@hamishmack hamishmack requested a review from angerman February 3, 2021 09:05
Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 3, 2021

@hamishmack hamishmack merged commit 250509f into master Feb 3, 2021
@iohk-bors iohk-bors bot deleted the hkm/nixpkgs-unstable branch February 3, 2021 09:38
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the version support matrix too.

@@ -25,4 +25,5 @@
allOverlays = import ./overlays args;
nixpkgsArgs = { inherit config overlays system; };
pkgs = import sources.nixpkgs nixpkgsArgs;
pkgs-unstable = import sources.nixpkgs-unstable nixpkgsArgs;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this should still be here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mainly use pkgs for debugging haskell.nix issues, by running things like:

nix-build -E '(import ./. {}).pkgs.haskell-nix.tool "ghc8103" "hello" "latest"'

I wanted to be able to continue to do this now I have upgraded to BigSur.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, now that I look at this, it's a bit weird that pkgs is there too. I get that these are useful for debugging... but surely our users shouldn't be using these attributes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should rename them debug and debug-unstable to make that clear.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or add debug.nix with attributes useful for debugging? The problem is the dual duty of default.nix as the place for all useful attributes and also our de-facto external interface.

@michaelpj
Copy link
Collaborator

#1028 for the doc

@akrmn akrmn mentioned this pull request Jun 7, 2021
booniepepper pushed a commit to booniepepper/haskell.nix that referenced this pull request Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hydra-do-build Enables PR jobset in Hydra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants