LicenseRef-OtherLicense is not free = false
#1006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [dependent-map](https://hackage.haskell.org/package/dependent-map) package for instance is not clear on which free license applies to which parts of the code, but that does not mean it is not free. `cabal2nix` maps LicenseRef-OtherLicense to `meta.license = "unknown"` `cabal-to-nix` and `haskell.nix` map it to a more detailed attribute set but it includes `free = false` and that causes packages like `dependent-map` to fail to install when `allowUnfree` has not been set. This change removes the `free` attribute altogether, which seems more principled than asserting that the `OtherLicense` cannot be `free`.
|
Worth a comment in the code about why we don't set |
deepfire
added a commit
to IntersectMBO/cardano-node
that referenced
this pull request
Feb 3, 2021
deepfire
added a commit
to IntersectMBO/cardano-node
that referenced
this pull request
Feb 3, 2021
deepfire
added a commit
to IntersectMBO/cardano-node
that referenced
this pull request
Feb 3, 2021
deepfire
added a commit
to IntersectMBO/cardano-node
that referenced
this pull request
Feb 3, 2021
This was referenced Feb 3, 2021
iohk-bors bot
added a commit
to input-output-hk/cardano-benchmarking
that referenced
this pull request
Feb 4, 2021
191: CA-2653: Nix updates & cleanups r=deepfire a=deepfire 1. Drop some of the legacy code. 2. Bump node to 1.25.1+ 3. Update Nix files to match the node 4. Bump `haskell.nix` to fix an eval issue (input-output-hk/haskell.nix#1006) Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io> Co-authored-by: Hamish Mackenzie <Hamish.K.Mackenzie@gmail.com>
iohk-bors bot
added a commit
to IntersectMBO/cardano-node
that referenced
this pull request
Feb 4, 2021
2330: CAD-2653 haskell.nix: bump to latest master r=deepfire a=deepfire Bump `haskell.nix` to latest master, as input-output-hk/haskell.nix#1006 fixes the following error that pops up during evaluation sometimes: ``` Package ‘Crypto-lib-Crypto-4.2.5.1’ in /nix/store/dxjrqxbhrw005w4z8fd9iglcazlz1gdg-haskell.nix-src/builder/comp-builder.nix:297 has an unfree license (‘Other License’), refusing to evaluate. ``` Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
booniepepper
pushed a commit
to booniepepper/haskell.nix
that referenced
this pull request
Feb 4, 2022
The [dependent-map](https://hackage.haskell.org/package/dependent-map) package for instance is not clear on which free license applies to which parts of the code, but that does not mean it is not free. `cabal2nix` maps LicenseRef-OtherLicense to `meta.license = "unknown"` `cabal-to-nix` and `haskell.nix` map it to a more detailed attribute set but it includes `free = false` and that causes packages like `dependent-map` to fail to install when `allowUnfree` has not been set. This change removes the `free` attribute altogether, which seems more principled than asserting that the `OtherLicense` cannot be `free`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependent-map
package for instance is not clear on which free license applies to
which parts of the code, but that does not mean it is not free.
cabal2nixmaps LicenseRef-OtherLicense tometa.license = "unknown"cabal-to-nixandhaskell.nixmap it to a more detailed attributeset but it includes
free = falseand that causes packages likedependent-mapto fail to install whenallowUnfreehas not been set.This change removes the
freeattribute altogether, which seems moreprincipled than asserting that the
OtherLicensecannot befree.