Skip to content

Commit 6e34587

Browse files
authored
LicenseRef-OtherLicense is not free = false (#1006)
The [dependent-map](https://hackage.haskell.org/package/dependent-map) package for instance is not clear on which free license applies to which parts of the code, but that does not mean it is not free. `cabal2nix` maps LicenseRef-OtherLicense to `meta.license = "unknown"` `cabal-to-nix` and `haskell.nix` map it to a more detailed attribute set but it includes `free = false` and that causes packages like `dependent-map` to fail to install when `allowUnfree` has not been set. This change removes the `free` attribute altogether, which seems more principled than asserting that the `OtherLicense` cannot be `free`.
1 parent 505130b commit 6e34587

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

lib/cabal-licenses.nix

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ in licenses // {
1414
shortName = "Other License";
1515
fullName = "Unidentified Other License";
1616
url = "https://spdx.github.io/spdx-spec/appendix-IV-SPDX-license-expressions/";
17-
free = false;
17+
# Not setting `free` here. The license may or may not be `free`.
18+
# See https://github.com/input-output-hk/haskell.nix/pull/1006
1819
};
1920
NONE = null;
2021
}

0 commit comments

Comments
 (0)