Skip to content

fix: continue instead of break in the submit task loop #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

fix: continue instead of break in the submit task loop #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tasks/submit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ impl SubmitTask {
};

if self.retrying_handle_inbound(&block, 3).await.is_err() {
break;
continue;
Copy link
Member

@prestwich prestwich May 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only way that retrying_handle_inbound exits with an err is if on L291 self.handle_inbound errors. which would mean an unhandled error in self.get_signature() or in self.submit_transaction()

self.submit_transaction() was unchanged in the previous PR

self.get_signature() can only error

  • if local signing errors
  • if sup_quincey errors

both of those are unrecoverable errors, and should result in breaking this loop and ending the submission task. this change suppresses those errors

it seems likely that whatever behavior was observed is related to the the quincey auth error that @rswanson was tracking

}
}
}
Expand Down
Loading