fix: continue instead of break in the submit task loop #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rswanson
approved these changes
May 13, 2025
Merge activity
|
prestwich
reviewed
May 14, 2025
| @@ -286,7 +286,7 @@ impl SubmitTask { | |||
| }; | |||
|
|
|||
| if self.retrying_handle_inbound(&block, 3).await.is_err() { | |||
| break; | |||
| continue; | |||
There was a problem hiding this comment.
the only way that retrying_handle_inbound exits with an err is if on L291 self.handle_inbound errors. which would mean an unhandled error in self.get_signature() or in self.submit_transaction()
self.submit_transaction() was unchanged in the previous PR
self.get_signature() can only error
- if local signing errors
- if
sup_quinceyerrors
both of those are unrecoverable errors, and should result in breaking this loop and ending the submission task. this change suppresses those errors
it seems likely that whatever behavior was observed is related to the the quincey auth error that @rswanson was tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: continue instead of break in the submit task loop
This PR makes the submit task future
continueinstead ofbreakwhen it is done finishing its retry loop.It was incorrectly breaking out of its submit loop after finishing one
retrying_handle_inboundcall.Fixes ENG-1077