qiita.config.jsonを使って、設定を変更できるようにする #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohakutsu
reviewed
Jul 4, 2023
src/commands/help.ts
Outdated
| --config <config_dir> | ||
| qiita-cliの設定情報を配置するディレクトリを指定 | ||
| --credential <credential_dir> | ||
| qiita-cliの認証情報を配置するディレクトリを指定 |
There was a problem hiding this comment.
[nits]
Suggested change
| qiita-cliの認証情報を配置するディレクトリを指定 | |
| Qiita CLIの認証情報を配置するディレクトリを指定 |
ohakutsu
reviewed
Jul 4, 2023
src/lib/config.ts
Outdated
| includePrivate: false, | ||
| } as UserConfig; | ||
|
|
||
| if (fsSync.existsSync(this.userConfigFilePath as string)) { |
There was a problem hiding this comment.
[nits & IMO]
Suggested change
| if (fsSync.existsSync(this.userConfigFilePath as string)) { | |
| if (fsSync.existsSync(this.getUserConfigFilePath())) { |
getty104
force-pushed
the
add-include-private-command
branch
from
d442ffa to
ac94360
Compare
getty104
force-pushed
the
add-include-private-command
branch
from
ac94360 to
1cea071
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
--configオプションを--credentialオプションに変更したqiita initでqiita.config.jsonを作成するようにしたqiita.config.jsonを用いて限定共有記事を取得するかどうかを選べるようにした（デフォルトはfalseにした）--configオプションでqiita.config.jsonのパスを指定できるようにしたWhy
--configを用いてローカルマシン上の認証情報を置く場所を指定できたが、configという名前がバッティングするので、元々--configとなっていたものを--credentialに変更したRefs
#5