CI: Simplify to read CI output and don't fail fast #3580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to fail fast. We used to fail fast, to avoid caches of failing PRs to overpopulate the CI caches, evicting known good build caches. However, PRs do not cache anything any more, and can only use the caches from current master. See 'caching.yml' for our caching set up.
fendor
changed the title
michaelpj
approved these changes
May 8, 2023
|
I agree with the reasoning 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dont rerun CI with various
lsp-testflags to increase the output verbosity.In my opinion, it makes it unnecessarily hard to find the failing test-case in CI, and I don't think anyone is reading these logs to actually debug test-cases.
Also, we don't want to fail fast.
We used to fail fast, to avoid caches of failing PRs to overpopulate the CI
caches, evicting known good build caches.
However, PRs do not cache anything any more, and can only use the caches from the current master.
See 'caching.yml' for our caching set up.