Skip to content

Add testutils to mark tests as flaky #3582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

fendor
Copy link
Collaborator

@fendor fendor commented May 7, 2023

Issue: #3581

This PR does three things:

  • Don't rerun CI test failures
  • Introduce combinators to mark tests as flaky
  • Mark all tests as flaky that fail on CI

@July541
Copy link
Collaborator

July541 commented May 8, 2023

Should we have a corresponding ticket for every flaky test?🤔️

It would be great if every knowFlaky has a github issue id in the code.

@fendor
Copy link
Collaborator Author

fendor commented May 8, 2023

Should we have a corresponding ticket for every flaky test?

It would be great, but looking at this CI result, I expect to have 40-50 flaky tests.
Having an issue for each of them looks like overkill to me. However, I think we should have an issue per package/plugin that has flaky tests. Then maybe maintainers also feel more inclined to look at their test suites.

@July541
Copy link
Collaborator

July541 commented May 8, 2023

Aha, 40-50 really exceeds my expectations, issues for every plugin are reasonable...

@fendor fendor force-pushed the enhance/mark-as-flaky branch from e0e3294 to 7bc494a Compare May 8, 2023 16:58
@fendor
Copy link
Collaborator Author

fendor commented May 9, 2023

Due to the extreme flakiness of lsp-tests, I'm back paddling my approach of marking everything that fails once as flaky. That's a bit disappointing, but I think we'd have to essentially mark every test as flaky eventually, since it is difficult to write a completely deterministic test with lsp-test (not necessarily the fault of lsp-test).
Thus, we run the test suite twice to wheat out the most flaky behaviour. If a test fails twice in a row, it is marked as flaky. It looks like this will allow us to have fewer flaky tests, thus creating one issue for each seems feasible again.

@fendor fendor force-pushed the enhance/mark-as-flaky branch from 901213e to 8559568 Compare May 9, 2023 16:54
@fendor
Copy link
Collaborator Author

fendor commented Oct 11, 2023

Closing as this seems to be useless for now and I don't intend to get this ready for merge any time soon.

@fendor fendor closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants