-
-
Notifications
You must be signed in to change notification settings - Fork 397
Add testutils to mark tests as flaky #3582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should we have a corresponding ticket for every flaky test?🤔️ It would be great if every knowFlaky has a github issue id in the code. |
It would be great, but looking at this CI result, I expect to have 40-50 flaky tests. |
Aha, 40-50 really exceeds my expectations, issues for every plugin are reasonable... |
e0e3294
to
7bc494a
Compare
Due to the extreme flakiness of lsp-tests, I'm back paddling my approach of marking everything that fails once as flaky. That's a bit disappointing, but I think we'd have to essentially mark every test as flaky eventually, since it is difficult to write a completely deterministic test with lsp-test (not necessarily the fault of lsp-test). |
901213e
to
8559568
Compare
Closing as this seems to be useless for now and I don't intend to get this ready for merge any time soon. |
Issue: #3581
This PR does three things: