Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Allow setting an explicit hoogle database location #887

Merged
merged 1 commit into from
Oct 28, 2018
Merged

Allow setting an explicit hoogle database location #887

merged 1 commit into from
Oct 28, 2018

Conversation

expipiplus1
Copy link
Contributor

Using the environment variable "HIE_HOOGLE_DATABASE"

@expipiplus1
Allow setting an explicit hoogle database location
9becc5e 
Using the environment variable "HIE_HOOGLE_DATABASE"
@expipiplus1 expipiplus1 mentioned this pull request Oct 20, 2018
Closed
lukel97
lukel97 approved these changes Oct 20, 2018
View reviewed changes
Copy link
Collaborator

@lukel97 lukel97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you add some info to the README about this?

@lukel97
Copy link
Collaborator

lukel97 commented Oct 26, 2018

@alanz @lorenzo is this ok to merge?

@alanz
Copy link
Collaborator

alanz commented Oct 26, 2018

Looks ok.

For completeness we could make it a command line param too, but maybe do that as a separate issue.

@alanz alanz mentioned this pull request Oct 28, 2018
Open
@alanz alanz merged commit b39f46f into haskell:master Oct 28, 2018
@lorenzo
Copy link
Collaborator

lorenzo commented Oct 28, 2018

This needs to be added to the readme too

lukel97 added a commit that referenced this pull request Oct 29, 2018
@lukel97
Add information about #887
7b4fd34 
Updates the README for #887
@alanz alanz added this to the prehistory milestone Feb 2, 2019
@expipiplus1
Copy link
Contributor Author

@bubba, thanks for adding this to the readme! And thanks for merging, @alanz!

@expipiplus1 expipiplus1 deleted the joe branch April 14, 2019 05:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lukel97 lukel97 lukel97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
prehistory
Development

Successfully merging this pull request may close these issues.
4 participants
@expipiplus1 @lukel97 @alanz @lorenzo