Create SQLAlchemyConnectionField through a factory method #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Biginteger can be too big for integer because integer is limited to 32 bit
This change allows api users to have the hand on the used ConnectionField implementation. (If filtering/sorting is wanted for example)
… the contructor-method gives the user the possibility to enhance the standard implementation
3 similar comments
3 similar comments
|
We merged by accident our master instead of the branch containing the changes. Sorry for the spam, but we're new to github. A new, clean pull request has been created. See #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriding the constructor-method gives the user the possibility to enhance the standard implementation of connection fields. (If you want to add filtering/sorting for example)