Skip to content

Create SQLAlchemyConnectionField through a factory method. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Create SQLAlchemyConnectionField through a factory method. #23

wants to merge 2 commits into from

Conversation

palmkevin
Copy link
Contributor

Overriding the constructor-method gives the user the possibility to enhance the standard implementation of connection fields. (If you want to add filtering/sorting for example)

… the contructor-method gives the user the possibility to enhance the standard implementation
@coveralls
Copy link

coveralls commented Nov 21, 2016

Coverage Status

Coverage decreased (-0.2%) to 90.083% when pulling e5bdaec on palmkevin:ConnectionFactory into c07b746 on graphql-python:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 90.083% when pulling e5bdaec on palmkevin:ConnectionFactory into c07b746 on graphql-python:master.

@coveralls
Copy link

coveralls commented Nov 21, 2016

Coverage Status

Coverage decreased (-0.2%) to 90.083% when pulling cbf0a22 on palmkevin:ConnectionFactory into c07b746 on graphql-python:master.

@palmkevin palmkevin closed this May 2, 2017
@palmkevin
Copy link
Contributor Author

I closed this pull request because it is duplicated by another pull request that has better code coverage
#46
The implementation of the other pull request is the same than mine (I am member of the labsolutionlu-organization)

@palmkevin palmkevin deleted the ConnectionFactory branch May 2, 2017 14:23
@palmkevin palmkevin restored the ConnectionFactory branch May 2, 2017 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants