ValueCache calls are made inside the batch load call #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d function and not the load method
bbakerman
changed the title
bbakerman
commented
Aug 8, 2021
| private ValueCache<Object, V> determineValueCache(DataLoaderOptions loaderOptions) { | ||
| return (ValueCache<Object, V>) loaderOptions.valueCache().orElseGet(ValueCache::defaultValueCache); | ||
| private ValueCache<K, V> determineValueCache(DataLoaderOptions loaderOptions) { | ||
| return (ValueCache<K, V>) loaderOptions.valueCache().orElseGet(ValueCache::defaultValueCache); |
There was a problem hiding this comment.
not sure why this was <Object,V> - weird
bbakerman
commented
Aug 8, 2021
| .whenComplete(setValueIntoCacheAndCompleteFuture(cacheKey, future)); | ||
| } | ||
| } | ||
| }); |
There was a problem hiding this comment.
This was the old async code in respect to the load call. This has been removed and cache lookup is now done in batch inside the "batch load" call done because of a call to dispatch
bbakerman
commented
Aug 8, 2021
| @@ -2,28 +2,26 @@ | |||
|
|
|||
| import org.dataloader.annotations.Internal; | |||
|
|
|||
There was a problem hiding this comment.
changed to supplier assert messages - better performance
bbakerman
commented
Aug 8, 2021
| } | ||
| } | ||
|
|
||
| CompletableFuture<V> invokeLoaderImmediately(K key, Object keyContext) { | ||
| CompletableFuture<V> invokeLoaderImmediately(K key, Object keyContext, boolean cachingEnabled) { |
There was a problem hiding this comment.
This is used when batching is off. We can still cache here
andimarek
reviewed
Aug 9, 2021
| boolean completeValueAfterCacheSet = loaderOptions.getValueCacheOptions().isCompleteValueAfterCacheSet(); | ||
| if (completeValueAfterCacheSet) { | ||
| return nonNull(valueCache | ||
| .setValues(missedKeys, missedValues), () -> "Your ValueCache.setValues function MUST return a non null promise") |
There was a problem hiding this comment.
promise is confusing: You should stick with CF imho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ValueCache is an async affair.
The previous PRs such as #91 handled it badly because they made the "load" call asynchronous with repect to the method returning a CF that might need to be dispatched
This fixes this by approaching it differently.
The BatchLoader is an async method and hence we can call the ValueCache then, meaning given 10 keys, if it gets 6 from the cache first it need only batch call for 4 after wards.
The results are then combined together again.
This opens another possibility - that is being able to do "batch cache" lookups. This has been added to ValueCache and if the implementation cant do batch lookup it just delegates back to the singleton
getcalls.For something backed by say REDIS (which can do batch cache calls) this may improve performance
The batch size here is no bigger than the max batch size options