This adds support for calling dispatch if the ValueCache takes timein get call
#91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakerman
commented
Jul 31, 2021
| if (!cachedLookupCompletedImmediately && !loaderCF.isDone()) { | ||
| if (loaderOptions.getValueCacheOptions().isDispatchOnCacheMiss()) { | ||
| dispatch(); | ||
| } |
There was a problem hiding this comment.
This is the fix - this will dispatch if the cache get miss took time to complete before we enqueued the batch loader call.
The danger here is that it interferes with other batch calls on this loader (premature batch calling) but the alternative is that it will hang.
This balances that out
The other alternative is that people use ScheduledDataLoaderRegistry to periodically tick and dispatch on schedule
|
This is not how we should fix the problem on reflection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ValueCache is an async affair. This means that the
dataLoader.load()call can return anddispatch()maybe call and that key will be missed in the batch function.This adds support to call dispatch if the
valueCache.get()call does not complete immediately (the default noop one will complete immediately)There is options to turn this behavior on and off - for example a
ScheduledDataLoaderRegistrywould be another technique to load missed batches periodically#90