Treat non-nullable scalars as scalars #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a non-nullable scalar as input type a regression was introduced by the upgrade of jackson. A jackson exception occurs internally in the MethodFieldResolver because the correct deserialiser/serialiser cannot be found. Somehow this was hidden when using earlier versions of jackson where this just worked anyhow, but due to changes in jackson this bug is uncovered. The correct way is of course to fix this in isScalarType to cover non-nullable scalars, and not rely on functionality in jackson which no longer seems to be supported.
|
Anything left to do before this could be merged? |
|
Sorry, didn't have time to look at it earlier. Thanks for the contribution! |
adisesha
added a commit
to adisesha/graphql-java-tools
that referenced
this pull request
Jan 22, 2020
This is fix for graphql-java-kickstart#240, and test for same issue. When array of non-nullable scalars is input, an error is thrown from Jackson ObjectMapper. The problem then was, NonNullType was ignored by MethodFieldResolver.isScalarType. Changes in graphql-java-kickstart#342 handles NonNullType but it doesn't handle NonNullType.type is ListType.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a non-nullable scalar as input type
a regression was introduced by the upgrade of jackson.
A jackson exception occurs internally in the MethodFieldResolver
because the correct deserialiser/serialiser cannot be found.
Somehow this was hidden when using earlier versions of jackson
where this just worked anyhow, but due to changes in jackson this
bug is uncovered. The correct way is of course to fix this in
isScalarType to cover non-nullable scalars, and not rely on
functionality in jackson which no longer seems to be supported.