Skip to content

isScalarType for non-null types #335

Closed
@tomas-c

Description

@tomas-c

TLDR:

isScalarType should support NotNullType.

Without it, mapper.convertValue(value, typeReference) is always called and sometimes fails with latest Jackson.

Background:

After upgrading from Spring Boot 2.1.8 to 2.2.2 I started getting an exception when using ApolloScalars.Upload scalar type. The exception said:

No serializer found for class java.io.FileDescriptor and no properties discovered to create BeanSerializer

Turns our new version of Spring came with a new version of Jackson which had removed conversion short-circuiting

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions