Add tests-on-macos #1279
Merged
Add tests-on-macos #1279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SVilgelm
changed the title
SVilgelm
force-pushed
the
latest
branch
6 times, most recently
from
7353d85 to
054c88a
Compare
SVilgelm
force-pushed
the
latest
branch
6 times, most recently
from
0206e42 to
a28a905
Compare
|
@ernado Could you make same changes here for the branch protection? |
|
I've updated protected branch rules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO we need to run the tests on macOS in same way we do for windows, so I added tests-on-macos as a parallel job with the go v1.14, so only ubuntu job will use different go version for testing.