Skip to content

Commit 703f2af

Browse files
author
Sergey Vilgelm
authored
Add tests-on-macos to cover all main platforms (#1279)
1 parent ad53b26 commit 703f2af

File tree

1 file changed

+15
-7
lines changed

1 file changed

+15
-7
lines changed

.github/workflows/pr.yml

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ jobs:
1111
# We already run the current golangci-lint in tests, but here we test
1212
# our GitHub action with the latest stable golangci-lint.
1313
golangci-lint:
14-
name: golangci-lint
1514
runs-on: ubuntu-latest
1615
steps:
1716
- uses: actions/checkout@v2
@@ -28,20 +27,29 @@ jobs:
2827
uses: actions/setup-go@v2
2928
with:
3029
go-version: 1.14 # test only the latest go version to speed up CI
31-
- name: Run tests on Windows
30+
- name: Run tests
3231
run: make.exe test
3332
continue-on-error: true
33+
tests-on-macos:
34+
needs: golangci-lint # run after golangci-lint action to not produce duplicated errors
35+
runs-on: macos-latest
36+
steps:
37+
- uses: actions/checkout@v2
38+
- name: Install Go
39+
uses: actions/setup-go@v2
40+
with:
41+
go-version: 1.14 # test only the latest go version to speed up CI
42+
- name: Run tests
43+
run: make test
44+
continue-on-error: true
3445
tests-on-unix:
3546
needs: golangci-lint # run after golangci-lint action to not produce duplicated errors
36-
runs-on: ${{ matrix.os }}
47+
runs-on: ubuntu-latest
3748
strategy:
3849
matrix:
3950
golang:
4051
- 1.13
4152
- 1.14
42-
os:
43-
- ubuntu-latest
44-
# don't enable mac os because it's machines are very slow
4553
steps:
4654
- uses: actions/checkout@v2
4755
- name: Install Go
@@ -54,7 +62,7 @@ jobs:
5462
key: ${{ runner.os }}-go-${{ matrix.golang }}-${{ hashFiles('**/go.sum') }}
5563
restore-keys: |
5664
${{ runner.os }}-go-${{ matrix.golang }}-
57-
- name: Run tests on Unix-like operating systems
65+
- name: Run tests
5866
run: make test
5967
check_generated:
6068
needs: golangci-lint # run after golangci-lint action to not produce duplicated errors

0 commit comments

Comments
 (0)