Skip to content

fix+enhanced py.ParseTupleAndKeywords() #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix+enhanced py.ParseTupleAndKeywords() #152

wants to merge 1 commit into from

Conversation

drew-512
Copy link
Contributor

Fixes keyword arg parsing for py.ParseTupleAndKeywords(), exposed by tests added in: PR151

GC load enhancement: parseFormat() no longer makes allocations, eliminating (often) multiple allocations per call.

@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #152 (af5c88f) into master (965bc08) will increase coverage by 0.00%.
The diff coverage is 78.04%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   74.54%   74.55%           
=======================================
  Files          64       64           
  Lines       11182    11191    +9     
=======================================
+ Hits         8336     8343    +7     
- Misses       2296     2297    +1     
- Partials      550      551    +1     
Impacted Files Coverage Δ
py/args.go 63.00% <78.04%> (+1.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 965bc08...af5c88f. Read the comment docs.

@sbinet
Copy link
Member

sbinet commented Jan 31, 2022

superceded by #151

@sbinet sbinet closed this Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants