Skip to content

kwarg testing (exposes bugs in py.ParseTupleAndKeywords) #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2022
Merged

kwarg testing (exposes bugs in py.ParseTupleAndKeywords) #151

merged 2 commits into from
Jan 31, 2022

Conversation

drew-512
Copy link
Contributor

This expands and restores testing for print with keyword args, exposing bugs in py.ParseTupleAndKeywords()

Accompanied with additional PR to merge branch hotfix-parse-kwargs

@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #151 (fdb62e7) into master (965bc08) will increase coverage by 0.01%.
The diff coverage is 78.04%.

❗ Current head fdb62e7 differs from pull request most recent head 0bb5b0b. Consider uploading reports for the commit 0bb5b0b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   74.54%   74.55%   +0.01%     
==========================================
  Files          64       64              
  Lines       11182    11191       +9     
==========================================
+ Hits         8336     8344       +8     
  Misses       2296     2296              
- Partials      550      551       +1     
Impacted Files Coverage Δ
py/args.go 63.00% <78.04%> (+1.46%) ⬆️
builtin/builtin.go 79.93% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 965bc08...0bb5b0b. Read the comment docs.

Drew O'Meara added 2 commits January 29, 2022 17:50
This CL also reduces the memory pressure of py.ParseTupleAndKeywords by
using a local bytes buffer.
Copy link
Member

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I took the liberty of cherry-picking #152 into this PR and pushing into your branch (with slight reword of the commit messages).

could you send another PR against go-python/license adding yourself to the AUTHORS and CONTRIBUTORS files?

then I'll merge this one.

@sbinet
Copy link
Member

sbinet commented Jan 31, 2022

needs go-python/license#16

@sbinet sbinet merged commit 2083f7d into go-python:master Jan 31, 2022
@sbinet
Copy link
Member

sbinet commented Jan 31, 2022

thanks a lot for sticking w/ us.

and welcome to go-python :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants