Upgrade bleve from v2.0.6 to v2.3.0

[lunny]

Possible fix #18118

[6543]

@lunny we have to migrate code ...

modules/indexer/code/bleve.go:427:17: cannot range over languagesFacet.Terms (type *search.TermFacets)

[Gusted]

Possible fix #18118

Unless some package is using bleve v2.3.0 whereby the compiled code is using that version instead of the vendored v2.0.6, then their isn't anything to fix. V2.3.0 introduces some breaking changes(which we are impacted by), but they shouldn't be happening on our current version. So it's rather how the question that it comes someone is using v2.3.0 instead of the vendored one. I'm not against this change, I'd just feel that it kind of works around a problem that shouldn't be happening.

[lunny]

@lunny we have to migrate code ...

modules/indexer/code/bleve.go:427:17: cannot range over languagesFacet.Terms (type *search.TermFacets)

done.

[lunny]

Looks like some performance optimization blevesearch/bleve#1404

[wxiaoguang]

My only question is that whether bleve 2.3.0 can read/write the data of 2.0.6.

If yes, it's good to follow the latest vendor package.

If no .... well, it's still fine to me but we need to tell users (or re-generate the indexers).

[lunny]

My only question is that whether bleve 2.3.0 can read/write the data of 2.0.6.

If yes, it's good to follow the latest vendor package.

If no .... well, it's still fine to me but we need to tell users (or re-generate the indexers).

There is no break changelog from 2.0.6 to 2.3.0 and I have a simple test, the upgrade is smooth.

[codecov-commenter]

Codecov Report

Merging #18132 (84909da) into main (1a4e2bf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main   #18132   +/-   ##
=======================================
  Coverage   45.01%   45.01%           
=======================================
  Files         825      825           
  Lines       91538    91538           
=======================================
+ Hits        41207    41208    +1     
+ Misses      43745    43743    -2     
- Partials     6586     6587    +1     

Impacted Files	Coverage Δ
modules/indexer/code/bleve.go	66.52% <100.00%> (ø)
modules/queue/queue_channel.go	95.00% <0.00%> (-1.67%)	⬇️
modules/queue/queue_bytefifo.go	59.28% <0.00%> (-0.60%)	⬇️
routers/api/v1/repo/pull.go	28.69% <0.00%> (-0.51%)	⬇️
modules/queue/workerpool.go	49.23% <0.00%> (+2.29%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a4e2bf...84909da. Read the comment docs.