range over the pointer of a slice

[azhai]

Gitea Version

e4e3df6

Git Version

2.34

Operating System

CentOS 7

How are you running Gitea?

In go 1.18 beta1:
TAGS="bindata" make build

Database

MySQL

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Description

modules/indexer/code/bleve.go:427:23: cannot range over languagesFacet.Terms (variable of type *search.TermFacets)

A similar bug in StackOverflow
golang-cannot-range-over-pointer-to-slice

Screenshots

[azhai]

github.com/blevesearch/bleve/v2 v2.3.0

[Gusted]

In go 1.18 beta1:
TAGS="bindata" make build

The golang version is still in beta. Does this error also popup on go 1.17.x?

I'm quite confused by the fact that golang could error at that point of the code.

gitea/modules/indexer/code/bleve.go

Line 427 in e4e3df6

for _, term := range languagesFacet.Terms {

Is totally correct code, as it will be looping over the type of Terms, which is TermFacets, which is a type alias for []*TermFacet, which is not the same type. It's currently search.TermFacets, but as shown in the screenshot it somehow managed itself to be a pointer type.

[azhai]

Change languagesFacet.Terms to languagesFacet.Terms.Terms()

#modules/indexer/code/bleve.go line 425
languagesFacet := result.Facets["languages"]
for _, term := range languagesFacet.Terms.Terms() {
}

[Gusted]

https://github.com/blevesearch/bleve/pull/1404/files Ah well bleve broke it. I'm not sure about how golang handles it, but gitea's bleve version is currently v2.0.6 and it's vendored as well. so I'm not sure if this is a bug. Given that we aren't supporting(unless bleve is upgraded within gitea) this version yet.