Skip to content

Replace GOGS with GITEA in variable names #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2016
Merged

Replace GOGS with GITEA in variable names #103

merged 3 commits into from
Nov 7, 2016

Conversation

strk
Copy link
Member

@strk strk commented Nov 7, 2016

Still use GOGS_WORK_DIR and GOGS_CUSTOM env variables
as a fallback if the equivalent GITEA_* are not set,
warning user about the need for change.

Also change "gogs" to "gitea" in webhook type name

Closes #87

@strk strk added this to the 1.0.0 milestone Nov 7, 2016
@xinity xinity added the type/enhancement An improvement of existing functionality label Nov 7, 2016
@xinity
Copy link
Contributor

xinity commented Nov 7, 2016

i'll probably rewrite the Dockerfile.
still LGTM to me

@strk
Copy link
Member Author

strk commented Nov 7, 2016

The WebHook name is still "gogs" and route includes /gogs/ component, so the API and templates are unchanged

@strk strk mentioned this pull request Nov 7, 2016
Closed
@codecov-io
Copy link

codecov-io commented Nov 7, 2016 •
edited
Loading

Current coverage is 2.24% (diff: 100%)

Merging #103 into master will not change coverage

@@            master      #103   diff @@
========================================
  Files           32        32          
  Lines         7521      7521          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           169       169          
  Misses        7335      7335          
  Partials        17        17

Powered by Codecov. Last update 1b962ba...30be1f4

bkcsoft
bkcsoft reviewed Nov 7, 2016
View reviewed changes
models/pull.go
@@ -26,7 +26,7 @@ var PullRequestQueue = sync.NewUniqueQueue(setting.Repository.PullRequestQueueLe
type PullRequestType int

const (
PULL_REQUEST_GOGS PullRequestType = iota
PULL_REQUEST_GITEA PullRequestType = iota
PLLL_ERQUEST_GIT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaning this up as well would be nice :)

@bkcsoft
Copy link
Member

bkcsoft commented Nov 7, 2016

Also maybe renaming the init-files? :)

@strk
Copy link
Member Author

strk commented Nov 7, 2016 via email

@strk
Copy link
Member Author

strk commented Nov 7, 2016 via email

@bkcsoft
Copy link
Member

bkcsoft commented Nov 7, 2016

What about this one? 😄 https://github.com/go-gitea/gitea/blob/master/scripts/systemd/gogs.service

@strk
Copy link
Member Author

strk commented Nov 7, 2016

Also fixes #102 with latest commit (uses "gitea" in all init scripts)

@strk strk mentioned this pull request Nov 7, 2016
Closed
metalmatze
metalmatze reviewed Nov 7, 2016
View reviewed changes
models/pull.go
@@ -26,8 +26,8 @@ var PullRequestQueue = sync.NewUniqueQueue(setting.Repository.PullRequestQueueLe
type PullRequestType int

const (
PULL_REQUEST_GOGS PullRequestType = iota
PLLL_ERQUEST_GIT
PULL_REQUEST_GITEA PullRequestType = iota
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Constants should be named lowerCamelCase for unexported ones and UpperCamelCase for exported ones.
https://github.com/golang/go/wiki/CodeReviewComments#mixed-caps

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a separate PR for cleaning that up ? I'm just focusing on ^GOGS^GITEA here...

(and maybe we could use some automatici linting check to spot those)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #110

strk added 3 commits November 7, 2016 16:05
@strk
Replace GOGS with GITEA in variable names
b7263f3 
Still use GOGS_WORK_DIR and GOGS_CUSTOM env variables
as a fallback if the equivalent GITEA_* are not set,
warning user about the need for change.

Does not change "gogs" to "gitea" in webhook type name
Because "gogs" hook type is part of the API (routes) and used
in templates...

Closes gogs#87
@strk
Rename and update init files to use "gitea" instead of "gogs"
145ab5c 
Closes gogs#102
@strk
Fix typo in unused constant name
30be1f4
@bkcsoft
Copy link
Member

bkcsoft commented Nov 7, 2016

LGTM

@strk strk merged commit ee963f6 into go-gitea:master Nov 7, 2016
@strk strk deleted the GOGS_drop branch November 7, 2016 15:31
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
lunny pushed a commit to lunny/gitea that referenced this pull request Feb 7, 2019
@strk @lafriks
Add GetFormatPatch receiver for a repository (go-gitea#103)
b3e9f25 
* Add GetFormatPatch receiver for a repository

Includes test

* Use binary for GetFormatPatch

Also add missing test file

* Add empty line
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@metalmatze metalmatze metalmatze left review comments

@bkcsoft bkcsoft bkcsoft left review comments

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Replace all GOGS_* variables
6 participants
@strk @xinity @codecov-io @bkcsoft @metalmatze @tboerger