Add doc for syntax in THEMES.md #2570
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naseschwarz
reviewed
Mar 19, 2025
THEMES.md
Outdated
| Example syntax theme: | ||
| ``` | ||
| ( | ||
| syntax : Some("InspiredGitHub"), |
There was a problem hiding this comment.
RON'd roundtrip this like
Suggested change
| syntax : Some("InspiredGitHub"), | |
| syntax: Some("InspiredGitHub"), |
THEMES.md
Outdated
| @@ -31,7 +31,14 @@ Notes: | |||
| * using a color like `yellow` might appear in whatever your terminal/theme defines for `yellow` | |||
| * valid colors can be found in ratatui's [Color](https://docs.rs/ratatui/latest/ratatui/style/enum.Color.html) struct. | |||
| * all customizable theme elements can be found in [`style.rs` in the `impl Default for Theme` block](https://github.com/gitui-org/gitui/blob/master/src/ui/style.rs#L305) | |||
| * the syntax highlighting theme can be defined using the element `syntax`. Currently, only default themes of the syntect library are supported, [available themes](https://github.com/trishume/syntect/blob/7fe13c0fd53cdfa0f9fea1aa14c5ba37f81d8b71/src/dumps.rs#L215). | |||
There was a problem hiding this comment.
Suggested change
| * the syntax highlighting theme can be defined using the element `syntax`. Currently, only default themes of the syntect library are supported, [available themes](https://github.com/trishume/syntect/blob/7fe13c0fd53cdfa0f9fea1aa14c5ba37f81d8b71/src/dumps.rs#L215). | |
| * the syntax highlighting theme can be defined using the element `syntax`. Currently, only [default themes of the syntect library are supported](https://github.com/trishume/syntect/blob/7fe13c0fd53cdfa0f9fea1aa14c5ba37f81d8b71/src/dumps.rs#L215). |
This was referenced Mar 19, 2025
1 task
|
This was merged via #2575. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2532 (comment)
It changes the following:
Adds documentation for syntax in THEMES.md
I followed the checklist:
- [ ] I added unittests[x] I ran
make checkwithout errors- [ ] I tested the overall application- [ ] I added an appropriate item to the changelog