Select out of the defaults syntect syntax themes in theme.ron #2532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extrawurst
reviewed
Feb 24, 2025
vlad-anger
suggested changes
Mar 15, 2025
|
Needs resolve then can be merged 👍 |
Done! |
|
@VasilisManol i missed this but can you also please update the theme docs accordingly? |
|
@extrawurst I have added a comment in the style.rs for the available default themes for syntax. In my view, syntax is just another customizable theme element, so the pointer in THEMES.md to style.rs seems enough for me. |
|
Yes please it's a bit specific and different to the other styles. Ideally an example and a link to the available styles |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #1931 discussed in #1928 .
It changes the following:
Enables selecting in the theme file, the syntax theme out of the defaults from syntect crate.
I followed the checklist:
addedextended unittestmake checkwithout errors