Skip to content

refactor: update notification footer styles #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Jun 4, 2024

handful of small tailwind tweaks

  • prevent avatar from being shrunk on overflow
  • allow horizontal scrolling on overflow (for notifications with lots of pills. This is a little quirky, so open to suggestions on a better method)
  • simplify margins by using gap

@setchy setchy added the refactor Refactoring of existing feature label Jun 4, 2024
@setchy setchy added this to the Release 5.7.0 milestone Jun 4, 2024
@afonsojramos
Copy link
Member

Before merging, do you have an example of an overflow? Might be worth looking over

@setchy
Copy link
Member Author

setchy commented Jun 4, 2024

Before merging, do you have an example of an overflow? Might be worth looking over

Screen.Recording.2024-06-04.at.11.09.57.AM.mov

@setchy
Copy link
Member Author

setchy commented Jun 4, 2024

would be nice to use less space for the update type and formatted datetime... but couldn't think of anything clean yet...

@bmulholland
Copy link
Collaborator

bmulholland commented Jun 4, 2024

I don't think I'd ever notice that horizontal scroll myself. Wrapping to new line isn't an option?

Edit: oh, ellipsis does sound reasonable. Affords additional content.

Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regardless of UX, I believe this code is a strict improvement and is good to go. IMHO.,other changes discussed above could/should be a separate step.

@setchy
Copy link
Member Author

setchy commented Jun 4, 2024

Regardless of UX, I believe this code is a strict improvement and is good to go. IMHO.,other changes discussed above could/should be a separate step.

Thanks @bmulholland. I think this is pragmatic and affords us more time to find alternative solutions without holding up the next release

@setchy setchy merged commit 6606c90 into main Jun 5, 2024
7 checks passed
@setchy setchy deleted the refactor/notification-footer-styling branch June 5, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants