-
Notifications
You must be signed in to change notification settings - Fork 275
refactor: update notification footer styles #1177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Before merging, do you have an example of an overflow? Might be worth looking over |
Screen.Recording.2024-06-04.at.11.09.57.AM.mov |
would be nice to use less space for the update type and formatted datetime... but couldn't think of anything clean yet... |
I don't think I'd ever notice that horizontal scroll myself. Wrapping to new line isn't an option? Edit: oh, ellipsis does sound reasonable. Affords additional content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regardless of UX, I believe this code is a strict improvement and is good to go. IMHO.,other changes discussed above could/should be a separate step.
Thanks @bmulholland. I think this is pragmatic and affords us more time to find alternative solutions without holding up the next release |
handful of small tailwind tweaks