Skip to content

Commit 6606c90

Browse files
authored
refactor: update notification footer styles (#1177)
* refactor: update notification footer styles * refactor: update notification footer styles
1 parent fc50408 commit 6606c90

File tree

3 files changed

+753
-896
lines changed

3 files changed

+753
-896
lines changed

src/components/NotificationRow.tsx

Lines changed: 32 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -115,48 +115,47 @@ export const NotificationRow: FC<IProps> = ({ notification, hostname }) => {
115115
</div>
116116

117117
<div
118-
className="flex-1 overflow-hidden"
118+
className="flex-1 whitespace-nowrap overflow-hidden overflow-ellipsis"
119119
onClick={() => openNotification()}
120120
onKeyDown={() => openNotification()}
121121
>
122122
<div
123-
className="mb-1 text-sm whitespace-nowrap overflow-ellipsis overflow-hidden cursor-pointer"
123+
className="mb-1 text-sm whitespace-nowrap cursor-pointer"
124124
role="main"
125125
title={notification.subject.title}
126126
>
127127
{notification.subject.title}
128128
</div>
129129

130-
<div className="text-xs text-capitalize whitespace-nowrap overflow-ellipsis overflow-hidden">
131-
<span className="flex items-center">
132-
<span title={updatedLabel} className="flex">
133-
{notification.subject.user ? (
134-
<span
135-
title="View User Profile"
136-
onClick={openUserProfile}
137-
onKeyDown={openUserProfile}
138-
>
139-
<img
140-
className="rounded-full w-4 h-4 cursor-pointer"
141-
src={notification.subject.user.avatar_url}
142-
title={notification.subject.user.login}
143-
alt={`${notification.subject.user.login}'s avatar`}
144-
/>
145-
</span>
146-
) : (
147-
<span>
148-
<FeedPersonIcon
149-
size={16}
150-
className="text-gray-500 dark:text-gray-300"
151-
/>
152-
</span>
153-
)}
154-
<span className="ml-1" title={reason.description}>
155-
{reason.title}
130+
<div className="text-xs text-capitalize">
131+
<span title={updatedLabel} className="flex items-center gap-1">
132+
{notification.subject.user ? (
133+
<span
134+
title="View User Profile"
135+
onClick={openUserProfile}
136+
onKeyDown={openUserProfile}
137+
className="flex-shrink-0"
138+
>
139+
<img
140+
className="rounded-full w-4 h-4 object-cover cursor-pointer"
141+
src={notification.subject.user.avatar_url}
142+
title={notification.subject.user.login}
143+
alt={`${notification.subject.user.login}'s avatar`}
144+
/>
145+
</span>
146+
) : (
147+
<span>
148+
<FeedPersonIcon
149+
size={16}
150+
className="text-gray-500 dark:text-gray-300"
151+
/>
156152
</span>
157-
<span className="ml-1">{updatedAt}</span>
153+
)}
154+
<span title={reason.description}>{reason.title}</span>
155+
<span>{updatedAt}</span>
156+
<span className="hover:overflow-auto">
158157
{notification.subject?.linkedIssues?.length > 0 && (
159-
<span className="ml-1" title={linkedIssuesPillDescription}>
158+
<span title={linkedIssuesPillDescription}>
160159
<button type="button" className={Constants.PILL_CLASS_NAME}>
161160
<IssueClosedIcon
162161
size={12}
@@ -175,11 +174,7 @@ export const NotificationRow: FC<IProps> = ({ notification, hostname }) => {
175174
}
176175

177176
return (
178-
<span
179-
key={review.state}
180-
title={icon.description}
181-
className="ml-1"
182-
>
177+
<span key={review.state} title={icon.description}>
183178
<button
184179
type="button"
185180
className={Constants.PILL_CLASS_NAME}
@@ -196,7 +191,7 @@ export const NotificationRow: FC<IProps> = ({ notification, hostname }) => {
196191
})
197192
: null}
198193
{notification.subject?.comments > 0 && (
199-
<span className="ml-1" title={commentsPillDescription}>
194+
<span title={commentsPillDescription}>
200195
<button type="button" className={Constants.PILL_CLASS_NAME}>
201196
<CommentIcon
202197
size={12}
@@ -208,7 +203,7 @@ export const NotificationRow: FC<IProps> = ({ notification, hostname }) => {
208203
</span>
209204
)}
210205
{notification.subject?.labels?.length > 0 && (
211-
<span className="ml-1" title={labelsPillDescription}>
206+
<span title={labelsPillDescription}>
212207
<button type="button" className={Constants.PILL_CLASS_NAME}>
213208
<TagIcon
214209
size={12}

0 commit comments

Comments
 (0)