Skip to content

chore(replay): Update README.md sample rate default values #7162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

lucas-zimerman
Copy link
Contributor

@lucas-zimerman lucas-zimerman commented Feb 13, 2023

#6878 altered on version 7.33.0 the default to 0 but the docs still point as if the default was 1.0

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

#skip-changelog

getsentry#6878 altered on version 7.33.0 the default to 0 but the docs still point as if the default was 1.0
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! Let's just make sure they're both updated.

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Lms24 Lms24 changed the title Update Replay README.md wrong default value chore(replay): Update README.md sample rate default values Feb 13, 2023
@Lms24 Lms24 merged commit 2bdda84 into getsentry:master Feb 13, 2023
@Lms24
Copy link
Member

Lms24 commented Feb 13, 2023

Ooops I missed the target branch 🙈 synced master->develop so everything is up to date.

@lucas-zimerman just FYI, we recently changed our branching model to gitflow. Next time, please open PRs against develop instead of master. And it's totally my fault that this went into master now, no worries :)

(although, considering that we GA replay today, it's probably good that this is on master anyway, so let's just call it a happy accident 😅 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants