feat(replay): Remove default sample rates for replay #6878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
force-pushed
the
fn/replay-default-sample-rate
branch
from
32f014f to
3470213
Compare
bruno-garcia
approved these changes
Jan 20, 2023
|
Once shipped, please amend the docs: https://docs.sentry.io/platforms/javascript/session-replay/configuration/ |
Lms24
approved these changes
Jan 20, 2023
Previously, they were: * `replaysSessionSampleRate: 0.1` * `replaysOnErrorSampleRate: 1.0` Now, you have to explicitly set the sample rates, otherwise they default to 0.
mydea
force-pushed
the
fn/replay-default-sample-rate
branch
from
3470213 to
70a81be
Compare
|
Breaking change in minor release 👏 |
Replay is in beta and still subject to change. We are still tweaking some options and details, so the usual semver stability guarantees do not apply yet! |
|
Okay thanks |
lucas-zimerman
added a commit
to lucas-zimerman/sentry-javascript
that referenced
this pull request
Feb 13, 2023
getsentry#6878 altered on version 7.33.0 the default to 0 but the docs still point as if the default was 1.0
This was referenced Feb 13, 2023
Lms24
pushed a commit
that referenced
this pull request
Feb 13, 2023
#6878 altered on version 7.33.0 the default to 0 but the docs still point as if the default was 1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, they were:
replaysSessionSampleRate: 0.1replaysOnErrorSampleRate: 1.0Now, you have to explicitly set the sample rates, otherwise they default to 0.
Closes #6775