Skip to content

feat: Add typedocs build to gh actions #3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

feat: Add typedocs build to gh actions #3873

wants to merge 3 commits into from

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Aug 5, 2021 •
edited
Loading

This re-adds the GH pages target to craft

  • Upgrade typescript
  • (optional) Fix react imports

ref: #3871

@HazAT HazAT self-assigned this Aug 5, 2021
@HazAT HazAT requested a review from kamilogorek as a code owner August 5, 2021 12:56
@HazAT HazAT mentioned this pull request Aug 5, 2021
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2021 •
edited
Loading

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.56 KB (0%)
@sentry/browser - Webpack 22.56 KB (0%)
@sentry/react - Webpack 22.59 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.99 KB (+0.01% 🔺)

rhcarvalho
rhcarvalho reviewed Aug 5, 2021
View reviewed changes
Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's run this only for release branches?

@HazAT
Copy link
Member Author

HazAT commented Sep 14, 2021

I gave up on doing this, didn't have time anymore.
The last state was a problem with TS version and using typedocs

There is a bug in typedocs and it only works with TS 4+ which we don't.
So we need to fix this once we upgraded to the latest TS version.

@HazAT HazAT removed their assignment Sep 14, 2021
@kamilogorek kamilogorek mentioned this pull request Sep 14, 2021
Closed
@AbhiPrasad AbhiPrasad deleted the feat/typedocs branch January 30, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhcarvalho rhcarvalho rhcarvalho left review comments

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HazAT @rhcarvalho @kamilogorek