chore: Cleanup unused comments #14864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
commented
Dec 30, 2024
| @@ -182,8 +182,6 @@ async function captureErrorAndGetEnvelopeTraceHeader(page: Page): Promise<Partia | |||
|
|
|||
| const [, errorEnvelopeTraceHeader] = (await errorEventPromise)[0]; | |||
|
|
|||
| // @ts-expect-error - EventEnvelopeHeaders type in (types/envelope.ts) suggests that trace_id is optional, | |||
There was a problem hiding this comment.
??? not sure why but this started failing for me locally...?
mydea
commented
Dec 30, 2024
| @@ -131,7 +131,6 @@ function _isIgnoredTransaction(event: Event, ignoreTransactions?: Array<string | | |||
| } | |||
|
|
|||
| function _isDeniedUrl(event: Event, denyUrls?: Array<string | RegExp>): boolean { | |||
| // TODO: Use Glob instead? | |||
There was a problem hiding this comment.
I think this is not relevant anymore?
mydea
commented
Dec 30, 2024
| @@ -19,8 +19,6 @@ interface Performance { | |||
|
|
|||
| /** | |||
| * Returns a timestamp in seconds since the UNIX epoch using the Date API. | |||
| * | |||
| * TODO(v8): Return type should be rounded. | |||
There was a problem hiding this comment.
IMHO this would break quite some things?
mydea
commented
Dec 30, 2024
| @@ -32,8 +32,7 @@ export function setContextOnScope(scope: Scope, context: Context): void { | |||
|
|
|||
| /** | |||
| * Get the context related to a scope. | |||
| * TODO v8: Use this for the `trace` functions. | |||
mydea
force-pushed
the
fn/cleanup-comments
branch
from
2df9dbf to
acddf1f
Compare
chargome
approved these changes
Jan 9, 2025
mydea
force-pushed
the
fn/cleanup-comments
branch
from
acddf1f to
a4a4b9e
Compare
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Lms24
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up some small comments.