WTF ???

mydea · mydea · commit acddf1fa6e76 · 2025-01-09T09:30:15.000+01:00
diff --git a/dev-packages/browser-integration-tests/suites/tracing/dsc-txn-name-update/test.ts b/dev-packages/browser-integration-tests/suites/tracing/dsc-txn-name-update/test.ts
@@ -182,8 +182,6 @@ async function captureErrorAndGetEnvelopeTraceHeader(page: Page): Promise<Partia
 
   const [, errorEnvelopeTraceHeader] = (await errorEventPromise)[0];
 
-  // @ts-expect-error - EventEnvelopeHeaders type in (types/envelope.ts) suggests that trace_id is optional,
-  // which the DynamicSamplingContext type does not permit.
   // TODO(v9): We should adjust the EventEnvelopeHeaders type because the trace header always needs to have a trace_id
   return errorEnvelopeTraceHeader;
 }

Original file line number	Diff line number	Diff line change
`@@ -182,8 +182,6 @@ async function captureErrorAndGetEnvelopeTraceHeader(page: Page): Promise<Partia`
`182`	`182`
`183`	`183`	`const [, errorEnvelopeTraceHeader] = (await errorEventPromise)[0];`
`184`	`184`
`185`		`- // @ts-expect-error - EventEnvelopeHeaders type in (types/envelope.ts) suggests that trace_id is optional,`
`186`		`- // which the DynamicSamplingContext type does not permit.`
`187`	`185`	`// TODO(v9): We should adjust the EventEnvelopeHeaders type because the trace header always needs to have a trace_id`
`188`	`186`	`return errorEnvelopeTraceHeader;`
`189`	`187`	`}`