meta(changelog): Add changelog for v8.0.0-alpha.8 #11301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent request (#11130) When switching the SvelteKit server side SDK to `@sentry/node` powered by Otel, the semantics behind `continueTrace` changed as outlined in #11199. TLDR: We previously called `continueTrace` in a nested way when dealing with sub-requests`*` in SvelteKit. In our old Node SDK, this did nothing; in the new SDK, this currently causes a new root span/transaction to be created for the sub request. This patch now ensures that we continue to send sub request spans as child spans of the top-level/parent request.
The debugger call stack does not include the `new Promise` frames that are parsed from `error.stack`. This means that when we go through the frames to apply the local variables, the frames don't match up and we bail. This patch ignores those frames when matching functions in the frames.
This functionality is no longer being used, so we can remove it and it's tests. Part of #9885 since it makes it easier to port over browsertracing into browser package.
Make `integration.setupOnce` accept no arguments. This will allow us to easily remove `addGlobalEventProcessor` which is deprecated API. This also means we can remove `IntegrationFnResult`, as the type signature of the functional and class based integrations are now the same. Next up - remove `addGlobalEventProcessor`!
chore: Update `master` to fix package.json conflicts
Feedback from Bruno. Also went ahead and updated https://github.com/getsentry/sentry-javascript/releases/tag/8.0.0-alpha.5 accordingly.
This seems to have issues in ESM builds (not just in astro, but also saw it in remix), so for now removing this from defaults - users can still add it manually if needed. We may find a better solution for this before v8 is stable.
…11266) The warning existed, but was not called
ref #10100 Removes `span.spanId`, `span.traceId`, and `span.parentSpanId`.
ref #10100 Removes `addGlobalEventProcessor` and adds migration guide.
Closes #10668 Rather than inject large unchecked JavaScript strings to run via `Runtime.evaluate`, when the ANR integration is enabled, we add a function to `global.__SENTRY_GET_SCOPES__` which can then be called via the debugger when the event loop is suspended.
Tests that an app built with webpack 5 and minified with terser can be built and sends events at runtime
Resolves: #11069 After checking the behaviour, it seems to me that we don't need to capture any Boom responses, as the errors that may cause a `5xx` response are already captured by the core logic. To add an option to control this behaviour, we need to update the usage of `hapiErrorPlugin`, converting it to a function signature, which IMO may not worth doing, as I'm not sure if users in general would need to use it. This also adds `expectError()` to the `node-integration-tests` runner to allow `5xx` responses to be tested.
…11152) (#11153) Fix #11152 This introduces an option `isRequiredLabel`, and I planned to also add `errorMessageText`. However, this PR is branched off from a version that is a couple days old. Right now, @c298lee is currently working on getsentry/sentry#63749, which is causing major changes and the current version on master doesn't work yet. Therefore, I didn't yet implement `errorMessageText`. So consider this PR as a PoC, and either feel free to tag me when the screenshot changes are done – then I'll redo the changes based on the version that supports screenshots – or add the option on your own; however you prefer 🙂 One open question: Until now, there was only the error message: > There was a problem submitting feedback, please wait and try again. Now, depending on the status code, we have three error messages: > - 'Unable to send Feedback. This is because of network issues, or because you are using an ad-blocker.' > - 'Unable to send Feedback. Invalid response from server.' > - 'Unable to send Feedback' Do you have a suggestion how we could make the message configurable, without introducing too many and redundant settings? Maybe we should go back to only one message? I'm not sure if an end-user cares about whether it is a network issue or a server error. --------- Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
Building on top of #11239, this removes usage of `getCurrentHub` in `profiling-node` package by passing in the defined client into the function. This also removes the `createProfilingEventFromTransaction`, which was totally unused.
Instead of extending `BatchSpanProcessor`, we handle this ourselves now. There may be additional improvements we can do here, but this should be OK for now! I added two tests to cover what we really want to achieve/show here: 1. Ensure that if a span & child span are ended after each other, but in the same tick, they are correctly sent. 2. Ensure that if a child span is ended later, it is skipped. By skipping the batched span processor, we can simplify our flushing a bit and also get rid of some of the delays. For now I kept the exporter as a separate class (it is not exported anyhow, so purely internal), we can eventually look into merging this or not, but this is just a moving-parts-around exercise then. This way, tests continued to work mostly, which is good I'd say.
ref #10100 Removes `span.sampled`, and rewrites transaction sampling to avoid mutating transaction.
ref #10100 Goodbye `makeMain`
ref #10100 more `getCurrentHub` usages bite the dust.
The remaining usages are shims + stuff we have for tests. Not sure how much test code we should delete.
Given our bundling setup is a little more complicated, this patch adds codecov bundle analysis for our just our npm builds (ESM and CJS). It generates the bundle name from the package.json Previous attempt: #10682 https://docs.codecov.com/docs/rollup-quick-start https://app.codecov.io/gh/getsentry/sentry-javascript/bundles
…__ (#11283) The TextEncoder option was removed in #10701 because all of the newly supported platforms support TextEncoder/Decoder. Sadly that's not true for React Native, yet. TextEncoder will be included in the next release of RN with Hermes. See the PR facebook/hermes@3863a36#diff-4bf4a4ab271f254baf2097be87be98333ec69eb2d41e074b81147656c33145eb We can not drop support of all the previous RN versions in the RN SDK v6 (the next major). To avoid passing the encoder option around the SDK, I propose adding polyfill properties to the global __SENTRY__ object which RN can use.
I inlined https://github.com/billyvg/github-fetch-workflow-artifact, basically, as it struggled to import this in esm, for whatever reason... now all the code is inlined, which is fine I guess 😬
I leave the other checks (e.g. in http integration) in there, for now (where we check if the url is sentry URL), but this should ensure we are also not picked up by any other OTEL instrumentation etc.
Addressing #11215, this updates the logs for `NodeFetch` to make it clearer what is happening. Also, we actually do not support Node <18 there, so updating this accordingly too.
…tests/test-applications/node-express-app (#11284)
… with designs (#11227) Updated some screenshot styles to align with design: - Changed cropping to more closely follow photoshop: darker background, white cropping corners + rectangle and additional black border for contrast if the screenshot is white - Changed naming to follow BES naming - Added padding so that the submit/cancel buttons are always visible without scrolling - Reduced blurriness of cropping rectangle <img width="1270" alt="image" src="https://github.com/getsentry/sentry-javascript/assets/55311782/df73a537-58f9-4f03-9edc-403039e61122"> Relates to getsentry/sentry#63749 ---------
#11016) Co-authored-by: s1gr1d <sigrid.huemer@posteo.at>
…1051) Instead, we have an internal utility for this now.
This PR ensures that `tracePropagationTargets` are respected for node API requests. I also updated the node-fetch instrumentation, because that fixed an issue where `http.url` was not correctly set. I also updated the other node-fastify E2E tests to be less flaky (we could have race conditions of transactions we were waiting for). I bumped `@types/node` to the correct version to ensure I can use `crypto` properly in tests (and that generally makes sense, I'd say). Closes #11272
Also add the changelog for v7.108.0.
size-limit report 📦
|
lforst
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds changelog for the new 8.0.0-alpha.8 release, and also adds the 7.108.0 changelog from the v7 branch.